Vidar Holen
|
27822a1f56
|
Warn about 'foo=bar echo $foo'
|
2013-12-14 16:06:19 -08:00 |
|
Vidar Holen
|
eb06b06475
|
Don't warn about single quoted vars for ssh
|
2013-12-14 15:28:58 -08:00 |
|
Vidar Holen
|
5d72432046
|
If printf string contains %, don't warn about using vars
|
2013-12-14 15:27:11 -08:00 |
|
Vidar Holen
|
a4d36ba0d2
|
Warn about while read f; do ssh "$f"; done
|
2013-11-29 23:05:41 -08:00 |
|
Vidar Holen
|
d603ee1e89
|
Don't warn for A&&B||C if C is echo/exit/assignment
|
2013-11-24 16:15:10 -08:00 |
|
Vidar Holen
|
4fc518c877
|
Cleaned up command matching code
|
2013-11-24 15:48:07 -08:00 |
|
Vidar Holen
|
7fda86d6e2
|
Fixed warning for 'exec foo; exit 3'
|
2013-11-24 14:48:12 -08:00 |
|
Vidar Holen
|
6905373b6c
|
Fix incorrect warning for 'foo > bar 2> bar'
|
2013-11-24 14:20:24 -08:00 |
|
Vidar Holen
|
1d8401d583
|
Assume variables have spaces by default
|
2013-11-17 16:16:58 -08:00 |
|
Vidar Holen
|
a89aee1a34
|
Assume variables have spaces/globs by default
|
2013-11-17 16:13:45 -08:00 |
|
Vidar Holen
|
4853dce3fe
|
Fixed wrong quoting warning for foo=" "; foo
|
2013-11-17 15:00:07 -08:00 |
|
Vidar Holen
|
e5e08df1d9
|
Numbered messages
|
2013-11-10 10:55:46 -08:00 |
|
Vidar Holen
|
8d265aa25e
|
Don't warn about expr if using : operator
|
2013-11-03 13:47:04 -08:00 |
|
Vidar Holen
|
8a3d259ae6
|
Don't warn about single quotes in args to perl
|
2013-11-03 12:47:44 -08:00 |
|
Vidar Holen
|
3a9ae0ebf1
|
Accept dir-/basename due to edge cases like "/" and "foo"
|
2013-11-03 12:42:11 -08:00 |
|
Vidar Holen
|
157fea73da
|
Suggest ./* instead of * for command arguments
|
2013-10-06 15:54:31 -07:00 |
|
Vidar Holen
|
b439f02b8e
|
Improved assignment parsing: track indices and += vs =
|
2013-10-06 14:44:43 -07:00 |
|
Vidar Holen
|
7c411b39ac
|
Fixed warnings for read -p "Name: "
|
2013-09-29 20:55:26 -07:00 |
|
Vidar Holen
|
fb5f72951d
|
Don't warn about unused variables for read ''
|
2013-09-12 19:11:42 -07:00 |
|
Vidar Holen
|
7630136d6c
|
Move command and variable lists to ShellCheck.Data.
|
2013-09-12 18:50:33 -07:00 |
|
Vidar Holen
|
58b8e0ab70
|
Suggest pgrep when grepping ps
|
2013-08-31 18:32:07 -07:00 |
|
Vidar Holen
|
9586a46c9c
|
Warn about assigned but unreferenced variables
|
2013-08-31 18:26:20 -07:00 |
|
Vidar Holen
|
bb49cf8e65
|
Parse the contents of unquoted here documents
|
2013-08-31 17:03:15 -07:00 |
|
Vidar Holen
|
de1fa61560
|
Warn about client side expansion in ssh strings/heredocs.
|
2013-08-03 21:19:32 -07:00 |
|
Vidar Holen
|
d0caa1e1df
|
Don't warn for 'find .. | xargs -0' or 'ls -N | ..'
|
2013-07-25 19:58:53 -07:00 |
|
Vidar Holen
|
62566ee016
|
Clarified warning for expr
|
2013-07-24 00:17:31 -07:00 |
|
Vidar Holen
|
c1731bd72c
|
Don't warn about redirecting sudo to /dev/null
|
2013-07-23 23:46:40 -07:00 |
|
Vidar Holen
|
6aab109afb
|
Fixed up some warning messages.
|
2013-07-23 23:13:28 -07:00 |
|
Vidar Holen
|
8c5f0a062e
|
Warn about suspicious quotes in "foo "$var" bar"
|
2013-07-23 22:48:35 -07:00 |
|
Vidar Holen
|
d28f1fff56
|
Tried to make [ foo=bar ] messages simpler
|
2013-07-23 21:53:01 -07:00 |
|
Vidar Holen
|
1784972af7
|
Don't warn about echo "--------" is posix mode
|
2013-07-23 21:40:55 -07:00 |
|
Vidar Holen
|
b147419717
|
Don't warn for $ on $(( ${array[refs]} ))
|
2013-07-23 21:29:19 -07:00 |
|
Vidar Holen
|
cd1368b434
|
Added $PWD as a variable likely to contain spaces
|
2013-07-23 21:03:43 -07:00 |
|
Vidar Holen
|
f348661e7e
|
Generalized for f in $(ls) warning, due to many edge cases.
|
2013-07-23 20:54:04 -07:00 |
|
Vidar Holen
|
3e39411b38
|
Don't suggest ${foo//bar/baz} for #!/bin/sh
|
2013-07-10 23:14:10 -07:00 |
|
Vidar Holen
|
3832ca9d5c
|
Simplified PS1 checks.
|
2013-07-09 23:43:27 -07:00 |
|
Vidar Holen
|
636c6a9336
|
Parser support for export a=(b c). Also declare/local/typeset.
|
2013-07-09 23:32:13 -07:00 |
|
Vidar Holen
|
6b9cad55a5
|
Better unquoted message, seeing as how it's so common.
|
2013-07-09 22:18:22 -07:00 |
|
Vidar Holen
|
4780da31c2
|
Added bashism warning for &>
|
2013-07-09 22:11:17 -07:00 |
|
Vidar Holen
|
d04262c70f
|
Fixed broken recursive backtick expansion.
|
2013-07-09 21:53:15 -07:00 |
|
Vidar Holen
|
8055b6f9c5
|
Fixed warning for trap '$VAR'
|
2013-07-09 09:26:48 -07:00 |
|
Vidar Holen
|
c3211e559d
|
Added check for for f in $(find ..) similar to $(ls)
|
2013-07-08 21:09:27 -07:00 |
|
Vidar Holen
|
3d47609e78
|
Warn for [ $foo = *glob* ]
|
2013-07-08 20:45:15 -07:00 |
|
Vidar Holen
|
599beff5b1
|
Moved shebang verification to parser
|
2013-07-08 09:39:54 -07:00 |
|
Vidar Holen
|
a08e60cd07
|
Don't try to parse scripts declared as perl, ruby or python
|
2013-07-07 13:22:29 -07:00 |
|
Vidar Holen
|
56e0119db1
|
Fixed some incorrect warnings for PS1 escapes.
|
2013-07-05 19:12:13 -07:00 |
|
Vidar Holen
|
76c5af2973
|
Parser support for $[..], plus deprecation warning.
|
2013-07-05 09:42:08 -07:00 |
|
Vidar Holen
|
a20a3499ed
|
Improved bad indirection detection
|
2013-07-05 09:15:08 -07:00 |
|
Vidar Holen
|
73c6202842
|
Fixed misplaced uuoc for 'cat foo' outside pipe.
|
2013-07-04 14:27:03 -07:00 |
|
Vidar Holen
|
66cebe7c7b
|
Don't warn about quoting when $var is the command name.
|
2013-07-04 13:49:00 -07:00 |
|
Vidar Holen
|
af4d24c6f6
|
Check for 'echo "\n"'.
|
2013-07-04 13:42:31 -07:00 |
|
Vidar Holen
|
fc3045232f
|
Don't warn about f=/dev/null in 'foo $f > $f'
|
2013-07-04 13:18:46 -07:00 |
|
Vidar Holen
|
d2c5802a9d
|
Fixed UUOC warning for 'cat * | ..'.
|
2013-07-04 12:26:59 -07:00 |
|
Vidar Holen
|
ab20747ef2
|
Removed warning for ~ in the middle of strings. Too common.
|
2013-07-04 12:01:34 -07:00 |
|
Vidar Holen
|
9e84ff66f7
|
Warn about $() but not quotes in 'if $(cmd); ..'
|
2013-07-04 11:44:36 -07:00 |
|
Vidar Holen
|
f557ac3324
|
Added check for 'exec foo; cmd'
|
2013-07-02 22:37:33 -07:00 |
|
Vidar Holen
|
5d46c8a53f
|
Added check for functions used with sudo/xargs/etc
|
2013-07-02 21:35:17 -07:00 |
|
Vidar Holen
|
99be2736a1
|
Doubled speed by applying all checks in one iteration.
|
2013-07-02 20:29:07 -07:00 |
|
Vidar Holen
|
6aafc86a67
|
Added check for './ file'. Apparently people do that.
|
2013-07-02 20:09:01 -07:00 |
|
Vidar Holen
|
9cfa25cb56
|
Added check for ~ in quotes
|
2013-07-02 19:52:09 -07:00 |
|
Vidar Holen
|
499f7c8733
|
Warn for possible bad quote nesting like 'echo 'foo''
|
2013-07-01 10:01:58 -07:00 |
|
Vidar Holen
|
652f8a24fa
|
Added most checks from 'checkbashisms'. Thanks to Braakman, Rodin and Gilbey!
|
2013-06-30 12:13:18 -07:00 |
|
Vidar Holen
|
f820298b6e
|
Added recursive parsing support for `..`
|
2013-06-26 21:04:39 -07:00 |
|
Vidar Holen
|
25ee7e20f4
|
Added awkward check for PS1 escapes outside \[..\]
|
2013-06-25 20:59:54 -07:00 |
|
Vidar Holen
|
51cd951baa
|
Added warnings for sudo cmd > file
|
2013-06-18 20:08:56 -07:00 |
|
Vidar Holen
|
1b8b3b84d0
|
Fixed broken test for for f in "*.mp3"; do ..
|
2013-05-29 21:05:15 -07:00 |
|
Vidar Holen
|
1dbbc51f86
|
Improved regex parsing. To think [[ f =~ f( ]] )* ]] is valid..
|
2013-05-28 21:32:15 -07:00 |
|
Vidar Holen
|
6b89f33d0c
|
Warn about arg='--foo="bar"'; cmd $arg
|
2013-05-28 20:06:20 -07:00 |
|
Vidar Holen
|
b279411d70
|
Rewrote variable tracking code for future expansion
|
2013-05-27 20:54:03 -07:00 |
|
Vidar Holen
|
fc1af1b918
|
Also check for overridden time parameters for /bin/sh
|
2013-05-25 22:43:17 -07:00 |
|
Vidar Holen
|
17cf796486
|
Different checks per shell, and increased bashism detection.
|
2013-05-25 22:33:21 -07:00 |
|
Vidar Holen
|
cf67bf2294
|
Added check for 'time --format' and such, which Bash swallows.
|
2013-05-23 22:28:12 -07:00 |
|
Vidar Holen
|
e8a0fe09bf
|
Added error for ${foo$n}
|
2013-05-23 21:47:25 -07:00 |
|
Vidar Holen
|
13d4ea6540
|
Don't complaing about lack of quotes for 'local' and 'declare'
|
2013-05-20 11:58:08 -07:00 |
|
Vidar Holen
|
92d0ae8b6b
|
Allow [ foo \> bar ], while warning for [[ .. \> .. ]] and [ 1 \< 2 ]
|
2013-05-14 15:59:58 -07:00 |
|
Vidar Holen
|
10d4abf235
|
Warn for test n > 4
|
2013-05-14 15:23:28 -07:00 |
|
Vidar Holen
|
2f21ced552
|
Warn for subshell modifications using 'let'
|
2013-05-02 12:38:47 -07:00 |
|
Vidar Holen
|
82b16b4076
|
Warn for [[ $foo > 3.14 ]]
|
2013-03-22 17:10:30 -07:00 |
|
Vidar Holen
|
9f244edae3
|
Warn on "grep foo*.jpg" and "grep *foo*"
|
2013-03-01 17:28:41 -08:00 |
|
Vidar Holen
|
d2e2d06978
|
Add check for [[ "foo" ]]
|
2013-02-14 19:43:43 -08:00 |
|
Vidar Holen
|
585529a636
|
Return list of notes rather than a Map -> Map
|
2013-02-11 19:26:40 -08:00 |
|
Vidar Holen
|
05cb806642
|
Also warn for '$((foo)) $(cmd) ${foo}', not just '$foo'
|
2013-02-07 17:53:47 -08:00 |
|
Vidar Holen
|
795af72cf7
|
Fixed warning for ${#@}
|
2013-02-06 22:35:24 -08:00 |
|
Vidar Holen
|
84f87002b7
|
Split up numerical and legal binary op function
|
2013-02-05 20:15:13 -08:00 |
|
Vidar Holen
|
dd115a6d35
|
Warn on trap "echo $num" USR1
|
2013-01-25 20:32:25 -08:00 |
|
Vidar Holen
|
f6f05234bf
|
Warn on for f in 1,2,3 and for f in ls;
|
2013-01-25 20:15:42 -08:00 |
|
Vidar Holen
|
0d3dded238
|
Check if =~ is applied to something that looks like a glob
|
2013-01-25 20:06:18 -08:00 |
|
Vidar Holen
|
389d5588d8
|
Make [[ foo=bar ]] check say 'operator' instead of '=', because !=
|
2013-01-22 14:50:30 -08:00 |
|
Vidar Holen
|
b517ad9e19
|
select loops and bases in arithmetic contexts
|
2012-12-31 18:48:57 -08:00 |
|
Vidar Holen
|
059ef63b44
|
Don't warn for awk '$1'
|
2012-12-12 18:27:57 -08:00 |
|
Vidar Holen
|
1d7c6f68b4
|
Fixed bad for f in $(ls *.mp3) after T_Glob
|
2012-12-06 23:43:19 -08:00 |
|
Vidar Holen
|
bb6c155341
|
{1..$n} is only a problem in Bash
|
2012-12-05 09:53:16 -08:00 |
|
Vidar Holen
|
1fb3380e68
|
Added warning for find . -execdir rm *.jpg \;
|
2012-12-02 18:10:00 -08:00 |
|
Vidar Holen
|
6402f7f4a3
|
Fixed space warning for foo=$(echo $foo)
|
2012-12-02 17:19:44 -08:00 |
|
Vidar Holen
|
d3a4c9852f
|
Read any -* as binary/unary op, and warn on unknown.
|
2012-12-02 14:50:31 -08:00 |
|
Vidar Holen
|
55a4c3c44f
|
Added check for bashisms with #!/bin/sh
|
2012-12-02 14:08:50 -08:00 |
|
Vidar Holen
|
1a4301ea98
|
Added check for "#!/usr/bin/env bash -x"
|
2012-12-02 12:40:46 -08:00 |
|
Vidar Holen
|
8c1ab0c9b6
|
Fixed warning for tr abc '[d*]'
|
2012-12-01 13:19:40 -08:00 |
|
Vidar Holen
|
ff85c67c29
|
Fixed mistaked message for tr '[:upper:]'
|
2012-11-30 16:13:42 -08:00 |
|
Vidar Holen
|
34259f16db
|
Fixed message for (($1))
|
2012-11-30 14:32:20 -08:00 |
|
Vidar Holen
|
1e3b429abe
|
Check for tr hello world
|
2012-11-29 20:11:47 -08:00 |
|
Vidar Holen
|
b718e5f108
|
Parser help with globs, fixed message for grep foo\*
|
2012-11-29 19:20:44 -08:00 |
|
Vidar Holen
|
1bc6086aec
|
Added check for find / -exec foo && bar \;
|
2012-11-28 22:21:58 -08:00 |
|
Vidar Holen
|
3308ac9173
|
Warning for dirname/basename
|
2012-11-28 21:06:58 -08:00 |
|
Vidar Holen
|
7d7624252b
|
Added check for for f in $(cat foo)
|
2012-11-28 11:38:54 -08:00 |
|
Vidar Holen
|
3b1ec7f84e
|
Check for [[ $foo =~ '.*' ]]
|
2012-11-28 00:16:08 -08:00 |
|
Vidar Holen
|
01d3e5e858
|
Fixed unquoted error for [ ! $(foo) ]
|
2012-11-27 23:59:08 -08:00 |
|
Vidar Holen
|
b2c1c103c1
|
Added check for $(expr 3 + 2)
|
2012-11-27 23:55:08 -08:00 |
|
Vidar Holen
|
8db22b02e1
|
Added check for while $((n>3)); do ..
|
2012-11-27 23:38:44 -08:00 |
|
Vidar Holen
|
396541f3c2
|
Stop treating backticks as literals.
|
2012-11-27 23:11:59 -08:00 |
|
Vidar Holen
|
0cbbee7b89
|
Added slightly better ${..} parsing
|
2012-11-27 23:05:39 -08:00 |
|
Vidar Holen
|
77a3e3b331
|
Fixed incorrectly calling [ -z $foo ] a tautology.
|
2012-11-27 20:40:13 -08:00 |
|
Vidar Holen
|
e8a2ac09c7
|
Added check for grep foo*
|
2012-11-27 20:26:41 -08:00 |
|
Vidar Holen
|
96c8a01017
|
Added check for find / -name *.php
|
2012-11-27 20:10:54 -08:00 |
|
Vidar Holen
|
100fff4835
|
Added grep | sed check like existing grep | awk.
|
2012-11-27 01:21:14 -08:00 |
|
Vidar Holen
|
1aeff4f955
|
Added more robust a=cat foo | grep bar checker
|
2012-11-27 01:05:32 -08:00 |
|
Vidar Holen
|
adfdc0a627
|
Added check for a=ls -l
|
2012-11-27 00:48:09 -08:00 |
|
Vidar Holen
|
a8715d2d5f
|
Added check for A=foo | grep bar
|
2012-11-27 00:41:10 -08:00 |
|
Vidar Holen
|
0ca6d0f6cc
|
Added extglobs as splitting words
|
2012-11-27 00:32:00 -08:00 |
|
Vidar Holen
|
131b9f0517
|
Added checks for tr a-z A-Z and [asdf]
|
2012-11-27 00:28:47 -08:00 |
|
Vidar Holen
|
ba5bb488d1
|
Case statements are now rightfully unquotable contexts
|
2012-11-27 00:11:23 -08:00 |
|
Vidar Holen
|
2ea4711ff4
|
Added check, for f in 'find /'; do ..
|
2012-11-26 22:58:30 -08:00 |
|
Vidar Holen
|
7025ebd633
|
Made unquoted $(..) check more robust
|
2012-11-26 21:52:47 -08:00 |
|
Vidar Holen
|
4a803d2e48
|
Removed trailing whitespace
|
2012-11-26 20:43:19 -08:00 |
|
Vidar Holen
|
f4afb9a88f
|
Added check for constant [[]] expression, e.g. [[ a == b ]]
|
2012-11-26 20:42:10 -08:00 |
|
Vidar Holen
|
d58bd400ea
|
Added check for echo $foo | wc -c
|
2012-11-25 00:07:53 -08:00 |
|
Vidar Holen
|
aaf5ac6f8f
|
Added check for echo $a | sed s/foo/bar/g
|
2012-11-24 20:38:37 -08:00 |
|
Vidar Holen
|
aae87fc030
|
Added better space/glob checks
|
2012-11-24 14:41:17 -08:00 |
|
Vidar Holen
|
5100bc0989
|
Added check for [[ a != foo || a != bar ]], and same for (( ))
|
2012-11-19 22:54:55 -08:00 |
|
Vidar Holen
|
6977963124
|
Added checks for multiple pipe combinations.
|
2012-11-19 21:52:26 -08:00 |
|
Vidar Holen
|
090b94161d
|
Fixed incorrect warning for foo=$3
|
2012-11-17 10:53:39 -08:00 |
|
Vidar Holen
|
9eac0bfab9
|
Homogenized punctuation across messages.
|
2012-11-16 22:20:35 -08:00 |
|
Vidar Holen
|
89b0168254
|
Fixed incorrect errors on [[ $1 ]]
|
2012-11-16 21:01:26 -08:00 |
|
Vidar Holen
|
258a13721e
|
Added readme and licenses
|
2012-11-16 19:43:05 -08:00 |
|
Vidar Holen
|
851de930c0
|
Removed bash, true and false from [ command ] check, since these could be values
|
2012-11-16 11:15:26 -08:00 |
|
Vidar Holen
|
a172c8a8b9
|
Fixed $(( ! n )) and incorrect warning on $(($?))
|
2012-11-16 11:07:10 -08:00 |
|
Vidar Holen
|
900c6d01d4
|
Cleaned up analytics notes
|
2012-11-16 10:22:04 -08:00 |
|
Vidar Holen
|
2581be14e4
|
Moved AST into its own file
|
2012-11-16 10:12:51 -08:00 |
|
Vidar Holen
|
5faf8e7141
|
Added check for printf "$var"
|
2012-11-16 09:53:35 -08:00 |
|
Vidar Holen
|
686c895858
|
Added check for [[ foo == $bar ]]
|
2012-11-15 23:43:57 -08:00 |
|
Vidar Holen
|
a2cc44a04d
|
Added check for $(($n))
|
2012-11-15 23:32:45 -08:00 |
|
Vidar Holen
|
ad9db04856
|
Fixed incorrect n=1 & n=foo$n and same for $((n++))
|
2012-11-15 23:23:08 -08:00 |
|
Vidar Holen
|
38c5c6f847
|
Added warning for {1..$N}
|
2012-11-08 21:55:24 -08:00 |
|
Vidar Holen
|
33913366b1
|
Fixed bug in allModifiedVariables
|
2012-11-08 21:08:20 -08:00 |
|
Vidar Holen
|
f9f2982c9f
|
Added check for [ a==b ]
|
2012-11-08 20:43:51 -08:00 |
|
Vidar Holen
|
97e886e6dd
|
Added more [[]]-related checks
|
2012-11-08 20:19:34 -08:00 |
|
Vidar Holen
|
99e765ff34
|
Minor text modifications
|
2012-11-07 18:27:12 -08:00 |
|
Vidar Holen
|
de31835676
|
Added reason in messages about subshells
|
2012-11-07 16:36:18 -08:00 |
|
Vidar Holen
|
e264f64266
|
Renamed from codename Shpell to final name ShellCheck.
|
2012-11-06 11:31:53 -08:00 |