Fixed up some warning messages.

This commit is contained in:
Vidar Holen 2013-07-23 23:13:28 -07:00
parent 8c5f0a062e
commit 6aab109afb
1 changed files with 2 additions and 3 deletions

View File

@ -471,9 +471,8 @@ checkForInLs t = try t
case deadSimple x of
("ls":n) ->
let warntype = if any ("-" `isPrefixOf`) n then warn else err in
warntype id $ "Iterate over globs (e.g. 'for f in */*.wav') whenever possible, as ls only works for simple, alphanumeric filenames."
("find":_) -> warn id $ "Don't use 'for " ++ f ++ " in $(find ...). "
++ "Use find -exec or a while read loop."
warntype id $ "Iterate over globs whenever possible (e.g. 'for f in */*.wav'), as for loops over ls will fail for filenames like 'my file*.txt'."
("find":_) -> warn id $ "Use find -exec or a while read loop instead, as for loops over find will fail for filenames like 'my file*.txt'."
_ -> return ()