7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-10-31 06:29:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Added check for $(expr 3 + 2)

Browse Source
This commit is contained in:
Vidar Holen
2012-11-27 23:55:08 -08:00
parent 55ea991da7
commit b2c1c103c1
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ShellCheck/Analytics.hs
View File

@@ -70,6 +70,7 @@ basicChecks = [
,checkFindNameGlob
,checkGrepRe
,checkDollarArithmeticCommand
,checkExpr
]
modifyMap = modify
@@ -177,6 +178,11 @@ checkUuoc (T_Pipeline _ (T_Redirecting _ _ f@(T_SimpleCommand id _ _):_:_)) =
_ -> return ()
checkUuoc _ = return ()
prop_checkExpr = verify checkExpr "foo=$(expr 3 + 2)"
checkExpr (T_SimpleCommand id _ (w:_)) | w `isCommand` "expr" =
style id "Use $((..)), ${} or [[ ]] in place of antiquated expr."
checkExpr _ = return ()
prop_checkPipePitfalls1 = verify checkPipePitfalls "foo | grep foo | awk bar"
prop_checkPipePitfalls2 = verifyNot checkPipePitfalls "foo | awk bar | grep foo"
prop_checkPipePitfalls3 = verify checkPipePitfalls "ls | grep -v mp3"