Commit Graph

1311 Commits

Author SHA1 Message Date
Vidar Holen 3e7c2bfec0 Warn about [ $a != x ] || [ $a != y ] 2019-06-02 09:26:54 -07:00
Vidar Holen 36bb1e7858 Mention that "-" is supported as a filename. (Fixes #1586) 2019-05-22 17:35:41 -07:00
Vidar Holen 95b1185882 Inform about ineffectual ! on commands (fixes #1531) 2019-05-22 17:14:28 -07:00
Vidar Holen 8efbecd64a Don't suggest removing braces from $((${x+1})) (fixes #1533) 2019-05-19 15:29:47 -07:00
Vidar Holen 52a9d90e1a
Merge pull request #1580 from virgilwashere/copyright
Update Copyright to year 2019; README linting
2019-05-19 12:03:15 -07:00
Virgil f5892f2d0d (docs)Fix typo in yaml markdown
Was aligned as per TOC 2nd.  Reverted to -
2019-05-17 07:41:12 +10:00
Vidar Holen de7541e656 Merge branch 'yetamrra-require-braces' 2019-05-14 18:57:44 -07:00
Vidar Holen 861b63aa77 Specify 'variable' in require-braces 2019-05-14 18:48:41 -07:00
Benjamin Gordon 64c9c83cc8 SC2250: New optional check for braces around variable references
Always using braces makes it harder to accidentally change a variable by
pasting other text next to it, but the warning is off by default because
it's definitely a style preference.  Omit special and positional
variables from the check because appending additional characters to them
already doesn't change parsing.
2019-05-14 11:01:38 -06:00
Benjamin Gordon aa3b709b5d Track whether braces were present in T_DollarBraced
References of the form $var and ${var} both map to the same structure in
the AST, which prevents any later analysis functions from distinguishing
them.  In preparation for adding checks that need this info, add a Bool
to T_DollarBraced that tracks whether the braces were seen at parsing
time and update all references so that this change is a no-op.
2019-05-14 11:01:38 -06:00
Benjamin Gordon 0358090b3c Refactor definition of special variables.
This ensures that the parser and other places that refer to special
variables can use the same list.
2019-05-14 08:57:56 -06:00
Virgil ea05271fa3 📝 Update Copyright to year 2019 and Markdown linting
- [x] 📝 Update Copyright to year 2019

- [x] 📝 MD009/no-trailing-spaces: Trailing spaces [Expected: 0 or 2; Actual: 1]
- [x] 📝 MD034/no-bare-urls: Bare URL used

- [ ] 📝 ~MD004/ul-style: Unordered list style [Expected: dash; Actual: asterisk]~
- [ ] ~add missing TOC entries~
2019-05-14 20:12:34 +10:00
Vidar Holen 50116e8aee Don't suggest [[..]] for sh in SC2081 (fixes #1562) 2019-05-13 20:45:53 -07:00
Vidar Holen 5ccaddbcc2 Promote `json1` as the primary JSON format 2019-05-13 19:31:55 -07:00
Vidar Holen 80b7e1e099
Merge pull request #1578 from yetamrra/tabstops
Allow variable tabstop widths
2019-05-13 19:25:01 -07:00
Benjamin Gordon 50af8aba29 Add json1 format that ignores tabs
The new json1 format works just like json except that it treats tabs as
single characters instead of 8-character tabstops.

The main use case is to allow editors to pass -fjson1 so that they can
consume the json output in a character-oriented way without breaking
backwards compatibility.

Also addresses #1048.
2019-05-13 10:55:16 -06:00
Vidar Holen 5fb1da6814 Replace verbose checks with optional checks 2019-05-12 19:14:04 -07:00
Vidar Holen 58205a3573 Emit resolved rather than apparent filename for 'source' (fixes #1579) 2019-05-12 15:55:37 -07:00
Vidar Holen 5b177d62cb Simplify docker instructions 2019-05-09 20:22:10 -07:00
Vidar Holen 0ab3a726d3 Merge branch 'efx-adjust-docker-usage' 2019-05-09 20:21:41 -07:00
Vidar Holen 2791a48444 Merge branch 'adjust-docker-usage' of https://github.com/efx/shellcheck into efx-adjust-docker-usage 2019-05-09 20:21:21 -07:00
Vidar Holen bb63d66f7c Delete trailing spaces 2019-05-09 20:17:35 -07:00
Vidar Holen d9e419d60f Add support for source-path directives (fixes #1577) 2019-05-09 19:54:41 -07:00
Vidar Holen aa4b24e458
Merge pull request #1570 from virgilwashere/readme-pandoc
docs: README: Update pandoc command to match `Setup.hs`
2019-05-09 17:38:21 -07:00
Virgil 1c7a9f8a2f
Merge branch 'master' into readme-pandoc 2019-05-09 20:32:07 +10:00
Vidar Holen 2521c1cf56 Tweak README 2019-05-08 18:04:51 -07:00
Vidar Holen 65e7f2059d
Merge pull request #1571 from virgilwashere/master
docs: add Chocolatey installation method
2019-05-08 17:53:48 -07:00
Vidar Holen 248858c13e
Merge pull request #1549 from Lin-Buo-Ren/patch/snap/improve-packaging
Improve snap packaging
2019-05-08 17:35:05 -07:00
Eli Flanagan c0d4c5a106 ensure docker invocation is ephemeral
Also adjust the tag to use the `:stable` tag mentioned in the prior
line.
2019-05-07 07:48:43 -04:00
Virgil ec25fb4052 📝 add Chocolatey installation method
- [x]  add Chocolatey for Windows installation
- [x] 🚨 add language types to code blocks
2019-05-05 22:59:35 +10:00
Vidar Holen a3cd5979a2 Update message for SC2171 2019-05-04 12:54:59 -07:00
Vidar Holen 37b24cc129 Don't warn about "a"b"c" in =~ regex (fixes #1565) 2019-05-04 12:18:45 -07:00
Virgil d72a5faa1f 📝 docs: Update pandoc to match `Setup.hs`
The sdist hook in [Setup.hs](Setup.hs) disables the `smart` extension
when creating man page.
2019-05-04 16:27:44 +10:00
Vidar Holen e2e65e1350 Warn about arithmetic base conversation in sh (fixes #1547) 2019-04-29 18:02:44 -07:00
Vidar Holen 6ccf9d6af1 Mention in manual that 'sh' means POSIX and not system 2019-04-27 17:25:20 -07:00
Vidar Holen 9470b9dc31 Don't mention arrays in SC2089 in sh/dash (fixes #1014) 2019-04-27 16:22:01 -07:00
Vidar Holen bf1003eae3 Auto-disable SC2119 when disabling SC2120 (fixes #703) 2019-04-27 15:20:07 -07:00
Vidar Holen 301705edea Merge branch 'epontan-root-option' 2019-04-24 18:52:04 -07:00
Vidar Holen c6c12f52bd Expand root paths into source paths 2019-04-24 18:51:24 -07:00
Pontus Andersson af46758ff1 Add option to look for sources in alternate root paths
Add a new optional flag "-r|--root ROOTPATHS", where ROOTPATHS is a
colon separated list of paths, that will look for external sources in
alternate roots.

This is particular useful when the run-time environment does not fully
match the development environment. The #shellcheck source=file directive
is useful, but has its limitations in certain scenarios. Also, in many
cases the directive could be removed from scripts when the root flag is
used.

Script example.bash:
  #!/bin/bash
  source /etc/foo/config

Example usage where etc/foo/config exists in skel/foo:
  # shellcheck -x -r skel/foo:skel/core example.bash
2019-04-22 17:54:42 +02:00
林博仁(Buo-ren Lin) 025c380b84 snap: Migrate to core18 base
This patch migrates the snap to core18 base, which should make the cabal
build work again.

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
2019-04-16 20:14:37 +08:00
林博仁(Buo-ren Lin) 10955a143c snap: Replace deprecated build and install keyword
These keywords has been obsoleted in Snapcraft 3.

Refer-to: The 'build' keyword has been replaced by 'override-build' <https://github.com/canonical-web-and-design/snappy-docs/blob/master/deprecation-notices/dn8.md>
Refer-to: The 'install' keyword has been replaced by 'override-build' <https://github.com/canonical-web-and-design/snappy-docs/blob/master/deprecation-notices/dn9.md>
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
2019-04-16 18:10:49 +08:00
林博仁(Buo-ren Lin) 67dbbcbd89 snap: Drop unneeded trailing slash in the `source` property
Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
2019-04-16 17:53:01 +08:00
林博仁(Buo-ren Lin) cef4c1a0bc snap: Flip `grade` property to stable
This allows the snap to be promoted to the `candidate` and the `stable` release channels

Signed-off-by: 林博仁(Buo-ren Lin) <Buo.Ren.Lin@gmail.com>
2019-04-16 17:48:34 +08:00
Vidar Holen b824294961 Limit SC2032 to likely command args (fixes #1537) 2019-04-14 20:58:01 -07:00
Vidar Holen 5b7354918f SC2249: When verbose, warn about missing default case (fixes #997) 2019-04-14 16:58:17 -07:00
Vidar Holen b76c0a8221 SC2248: Warn about unquoted variables without special chars 2019-04-13 20:19:13 -07:00
Vidar Holen c860b74505 Set SC2243/SC2244 level to "verbose" 2019-04-13 13:40:18 -07:00
Vidar Holen 9652ccfdbd Add a verbose mode: `-S verbose` 2019-04-13 13:16:41 -07:00
Vidar Holen f514f5f735 Warn about flipped $ and " in $"(cmd)" (fixes #1517) 2019-03-20 22:10:04 -07:00