mirror of
https://github.com/koalaman/shellcheck.git
synced 2025-08-08 00:07:56 +08:00
Don't mention arrays in SC2089 in sh/dash (fixes #1014)
This commit is contained in:
@@ -1822,12 +1822,16 @@ checkQuotesInLiterals params t =
|
||||
&& not (isQuoteFree parents expr)
|
||||
&& not (squashesQuotes expr)
|
||||
then [
|
||||
makeComment WarningC (fromJust assignment) 2089
|
||||
"Quotes/backslashes will be treated literally. Use an array.",
|
||||
makeComment WarningC (fromJust assignment) 2089 $
|
||||
"Quotes/backslashes will be treated literally. " ++ suggestion,
|
||||
makeComment WarningC (getId expr) 2090
|
||||
"Quotes/backslashes in this variable will not be respected."
|
||||
]
|
||||
else [])
|
||||
suggestion =
|
||||
if supportsArrays (shellType params)
|
||||
then "Use an array."
|
||||
else "Rewrite using set/\"$@\" or functions."
|
||||
|
||||
|
||||
prop_checkFunctionsUsedExternally1 =
|
||||
|
@@ -940,5 +940,7 @@ getOpts flagTokenizer string cmd = process flags
|
||||
more <- process rest2
|
||||
return $ (flag1, token1) : more
|
||||
|
||||
supportsArrays shell = shell == Bash || shell == Ksh
|
||||
|
||||
return []
|
||||
runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |])
|
||||
|
Reference in New Issue
Block a user