Joseph C. Sible
e820a5642b
Adjust a pattern to get rid of a fromJust
2020-02-02 00:40:22 -05:00
Joseph C. Sible
392b57b8e8
Use maybe instead of isJust and fromJust
2020-02-02 00:27:05 -05:00
Joseph C. Sible
6595e14d25
Adjust a pattern to avoid tail
2020-02-02 00:24:24 -05:00
Joseph C. Sible
115ef29079
Use pattern matching instead of head
2020-02-02 00:16:59 -05:00
Joseph C. Sible
76b798394f
Use case matching instead of null
...
Using null followed by a head, tail, or a partial pattern match is
an anti-pattern. Use case matching instead.
2020-02-01 23:07:16 -05:00
Joseph C. Sible
8a005526cc
Use drop instead of splitAt since we only use the second half
2020-02-01 23:04:04 -05:00
Joseph C. Sible
c29b6afa56
Use null instead of comparing with empty lists
2020-02-01 23:04:04 -05:00
Joseph C. Sible
e6e89d68fd
Use list comprehensions instead of clunky combinations of map and filter
2020-02-01 23:04:04 -05:00
Joseph C. Sible
f25b8bd03a
Use gets instead of fmapping the result of get
2020-02-01 22:50:20 -05:00
Joseph C. Sible
d7278b95f2
Remove unnecessary "map snd"
2020-02-01 22:50:19 -05:00
Joseph C. Sible
5487b3f229
Use sortOn instead of sortBy and comparing
2020-02-01 22:50:18 -05:00
Joseph C. Sible
28978a8b65
Use maybe instead of fromMaybe and fmap
2020-02-01 22:50:17 -05:00
Joseph C. Sible
f5c6771016
Use find instead of listToMaybe and filter
2020-02-01 22:50:16 -05:00
Joseph C. Sible
0f48bb78a5
Remove incorrect otherwise
...
You're supposed to use otherwise where you need a Boolean, not a pattern
match. This is misleadingly shadowing the real otherwise. Use _ instead.
2020-02-01 22:50:14 -05:00
Joseph C. Sible
93be86f988
Use "drop 1" instead of clumsily rewriting it
2020-02-01 22:50:14 -05:00
Joseph C. Sible
3449e6be21
Get rid of our getOpt, as it already exists as lookup
2020-02-01 22:50:13 -05:00
Joseph C. Sible
2e52c2b56a
Use notElem instead of not on the result of elem
2020-02-01 22:50:11 -05:00
Vidar Holen
ff5f29f661
Merge pull request #1784 from ArturKlauser/travis-warnings
...
Fix Travis warnings
2020-01-05 12:53:42 -08:00
Vidar Holen
c7bf1fd96e
Merge pull request #1783 from ArturKlauser/fix-osx-travis-build
...
Fix OSX build on Travis
2020-01-05 12:53:28 -08:00
Artur Klauser
b96b7f35f4
Fix Travis warnings
...
Fixing the following Travis build config validation warnings:
* root: deprecated key sudo (The key `sudo` has no effect anymore.)
* root: missing os, using the default linux
* deploy: key local-dir is not underscored, using local_dir
* language: value sh is an alias for shell, using shell
* root: key matrix is an alias for jobs, using jobs
2019-12-28 14:24:23 +01:00
Artur Klauser
926ee54036
Fix OSX build on Travis
...
Symlink was failing due to pre-existing target file:
sudo ln -s /usr/local/bin/gsha512sum /usr/local/bin/sha512sum
ln: /usr/local/bin/sha512sum: File exists
2019-12-28 09:51:11 +01:00
Vidar Holen
9008a6833b
Merge pull request #1711 from renatoassis01/master
...
add github actions link
2019-12-21 18:53:16 -08:00
Vidar Holen
ce60a1764f
Merge branch 'jabberabbe-iss1724-builtin-support'
2019-12-21 18:50:52 -08:00
Vidar Holen
cbcca528ae
Merge branch 'iss1724-builtin-support' of https://github.com/jabberabbe/shellcheck into jabberabbe-iss1724-builtin-support
2019-12-21 18:13:07 -08:00
Vidar Holen
83187dafd7
Added a unit test for parsing shell keyword case branches
2019-12-21 17:59:09 -08:00
Vidar Holen
d919aaa847
Merge branch 'Gandalf--issue_1731_case_pattern_literals'
2019-12-21 17:56:26 -08:00
Gandalf-
3f296a08c1
Issue 1731 Literals in case patterns
...
https://github.com/koalaman/shellcheck/issues/1731
Any literal except esac is valid pattern in a case statement
2019-12-18 20:23:48 -08:00
Vidar Holen
0f15fa49ba
Make SC2230 optional
2019-12-07 16:11:49 -08:00
Vidar Holen
0a4580e234
Mention that ShellCheck is now compatible with Cabal 3
2019-12-07 16:11:49 -08:00
Vidar Holen
5c7d8129ad
Try to search for binary on macOS/Cabal3
2019-11-18 17:12:25 -08:00
Vidar Holen
e075cde357
Revert docker image to 18.04 since ld fails on later versions
2019-11-16 11:46:58 -08:00
Vidar Holen
9f578f41a1
Explicitly add 'mappend' for old GHC versions
2019-11-16 11:16:15 -08:00
Vidar Holen
2c026f1ec7
Support Cabal 3. Man page no longer autobuilds.
2019-11-16 11:06:18 -08:00
Vidar Holen
874bdcb514
Merge pull request #1728 from mgttlinger/patch-1
...
Nix install instructions
2019-11-15 21:03:01 -08:00
Vidar Holen
fa3eb47193
Merge pull request #1716 from ryantig/ryantig-patch-1
...
Update README.md
2019-11-15 21:01:24 -08:00
Vidar Holen
989ac32625
Merge pull request #1734 from gabrielelana/braced-regular-for
...
Parse regular `for` with body in curly braces
2019-11-15 20:59:51 -08:00
Vidar Holen
2bbfd0570d
Merge pull request #1735 from gabrielelana/quoted-heredoc
...
Support for heredoc quoted token like `'"FOO"`
2019-11-15 20:27:10 -08:00
Vidar Holen
9b1befadc1
Update brew before building on macOS due to incompatible Ruby
2019-11-15 09:26:01 -08:00
Vidar Holen
f44624a9c0
Hide <> from Writer to not conflict with Semigroup
2019-11-14 20:02:25 -08:00
Vidar Holen
c75bbcbd60
Include missing Semigroup import
2019-11-13 22:10:27 -08:00
Vidar Holen
daa9c08dd5
Merge pull request #1749 from lvjp/simple-docker-build
...
Make image build process a bit simpler
2019-11-13 22:04:14 -08:00
Vidar Holen
4da34fbc64
Merge branch 'translatedVars'
2019-11-13 21:48:53 -08:00
Vidar Holen
4a63a3a8bd
For SC2256, make sure the complete string is a variable name
2019-11-13 21:48:01 -08:00
Benjamin Gordon
2341a4c683
SC2256: Check for translated strings matching known variables
...
SC2247 already warns about translated strings that look like $"(foo)" or
$"{foo}". Since typical use of translated strings is to translate whole
messages, a string like $"foo" is likely to be a similar mistake if foo
is the name of an existing variable. Conversely, a string like
$"foo bar" is potentially meant to be a message id even if foo is a
known variable.
Add a warning for the $"foo" case, but make it separate from the
existing warning so that projects that reuse variable names as their
message ids can separately disable the new warning.
2019-11-13 16:41:16 -07:00
Laurent VERDOÏA
7eb6b35cb0
Make image build process a bit simpler
...
Take full leverage of multi-stage docker build.
2019-11-09 10:26:59 +01:00
Vidar Holen
93eca1cb8e
Only trigger SC1014 when command is a complete word ( fixes #1737 )
2019-11-03 13:26:23 -08:00
Vidar Holen
e701cf6fad
Warn about [ x -ot y ] in POSIX mode
2019-11-03 13:25:35 -08:00
Vidar Holen
5962b01816
Correctly handle empty variables for SC2086 ( fixes #1722 )
2019-11-03 12:46:25 -08:00
Tito Sacchi
5becc673b2
Modify CHANGELOG.md
2019-11-01 14:36:15 +01:00
Tito Sacchi
84ca7711c4
Make command-specific checks act on `builtin ...`
...
Now if shellchecks encounters a command like `builtin cmd ...`
it applies the same check that would be applied to `cmd ...`.
2019-11-01 14:28:00 +01:00