7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Also check for overridden time parameters for /bin/sh

This commit is contained in:
Vidar Holen 2013-05-25 22:43:17 -07:00
parent 17cf796486
commit fc1af1b918
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ShellCheck/Analytics.hs
View File

@ -39,7 +39,10 @@ genericChecks = concat [
,[checkShebang]
]
checksFor Sh = map runBasicAnalysis [ checkBashisms ]
checksFor Sh = map runBasicAnalysis [
checkBashisms
,checkTimeParameters
]
checksFor Ksh = [ ]
checksFor Zsh = map runBasicAnalysis [ checkTimeParameters ]
checksFor Bash = map runBasicAnalysis [
@ -916,7 +919,7 @@ prop_checkTimeParameters3 = verifyNot checkTimeParameters "time -p foo"
checkTimeParameters = checkUnqualifiedCommand "time" f where -- TODO make bash specific
f (x:_) = let s = concat $ deadSimple x in
if "-" `isPrefixOf` s && s /= "-p" then
info (getId x) "The shell overrides 'time' as seen in man time(1). Use 'command time ..' for that one."
info (getId x) "The shell may override 'time' as seen in man time(1). Use 'command time ..' for that one."
else return ()
f _ = return ()