From fc1af1b9188c1cee32b57d528481d91215b3e41b Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Sat, 25 May 2013 22:43:17 -0700 Subject: [PATCH] Also check for overridden time parameters for /bin/sh --- ShellCheck/Analytics.hs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index 60007c9..0d05bf9 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -39,7 +39,10 @@ genericChecks = concat [ ,[checkShebang] ] -checksFor Sh = map runBasicAnalysis [ checkBashisms ] +checksFor Sh = map runBasicAnalysis [ + checkBashisms + ,checkTimeParameters + ] checksFor Ksh = [ ] checksFor Zsh = map runBasicAnalysis [ checkTimeParameters ] checksFor Bash = map runBasicAnalysis [ @@ -916,7 +919,7 @@ prop_checkTimeParameters3 = verifyNot checkTimeParameters "time -p foo" checkTimeParameters = checkUnqualifiedCommand "time" f where -- TODO make bash specific f (x:_) = let s = concat $ deadSimple x in if "-" `isPrefixOf` s && s /= "-p" then - info (getId x) "The shell overrides 'time' as seen in man time(1). Use 'command time ..' for that one." + info (getId x) "The shell may override 'time' as seen in man time(1). Use 'command time ..' for that one." else return () f _ = return ()