7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't warn about splitting in select statements

This commit is contained in:
Vidar Holen 2014-05-17 12:06:04 -07:00
parent 6cd454e88b
commit d21b3362b2
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ShellCheck/Analytics.hs
View File

@ -1279,7 +1279,9 @@ isQuoteFree tree t =
T_CaseExpression _ _ _ -> return True T_CaseExpression _ _ _ -> return True
T_HereDoc _ _ _ _ _ -> return True T_HereDoc _ _ _ _ _ -> return True
T_DollarBraced {} -> return True T_DollarBraced {} -> return True
T_ForIn {} -> return True -- Pragmatically assume it's desirable here -- Pragmatically assume it's desirable to split here
T_ForIn {} -> return True
T_SelectIn {} -> return True
_ -> Nothing _ -> Nothing
isParamTo tree cmd t = isParamTo tree cmd t =
@ -2047,6 +2049,7 @@ prop_checkSpacefulnessH = verifyTree checkSpacefulness "echo foo=$1"
prop_checkSpacefulnessI = verifyNotTree checkSpacefulness "$1 --flags" prop_checkSpacefulnessI = verifyNotTree checkSpacefulness "$1 --flags"
prop_checkSpacefulnessJ = verifyTree checkSpacefulness "echo $PWD" prop_checkSpacefulnessJ = verifyTree checkSpacefulness "echo $PWD"
prop_checkSpacefulnessK = verifyNotTree checkSpacefulness "n+='foo bar'" prop_checkSpacefulnessK = verifyNotTree checkSpacefulness "n+='foo bar'"
prop_checkSpacefulnessL = verifyNotTree checkSpacefulness "select foo in $bar; do true; done"
checkSpacefulness params t = checkSpacefulness params t =
doVariableFlowAnalysis readF writeF (Map.fromList defaults) (variableFlow params) doVariableFlowAnalysis readF writeF (Map.fromList defaults) (variableFlow params)