From d21b3362b2011561a3f71899deccc3909d7e7a6b Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Sat, 17 May 2014 12:06:04 -0700 Subject: [PATCH] Don't warn about splitting in select statements --- ShellCheck/Analytics.hs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index 0486bb6..d68617e 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -1279,7 +1279,9 @@ isQuoteFree tree t = T_CaseExpression _ _ _ -> return True T_HereDoc _ _ _ _ _ -> return True T_DollarBraced {} -> return True - T_ForIn {} -> return True -- Pragmatically assume it's desirable here + -- Pragmatically assume it's desirable to split here + T_ForIn {} -> return True + T_SelectIn {} -> return True _ -> Nothing isParamTo tree cmd t = @@ -2047,6 +2049,7 @@ prop_checkSpacefulnessH = verifyTree checkSpacefulness "echo foo=$1" prop_checkSpacefulnessI = verifyNotTree checkSpacefulness "$1 --flags" prop_checkSpacefulnessJ = verifyTree checkSpacefulness "echo $PWD" prop_checkSpacefulnessK = verifyNotTree checkSpacefulness "n+='foo bar'" +prop_checkSpacefulnessL = verifyNotTree checkSpacefulness "select foo in $bar; do true; done" checkSpacefulness params t = doVariableFlowAnalysis readF writeF (Map.fromList defaults) (variableFlow params)