7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing warnings for {$i..10} similar to {1..$i}

This commit is contained in:
Vidar Holen 2016-04-23 16:00:56 -07:00
parent 2f0ae44de4
commit 7551a241ad
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ShellCheck/Analytics.hs
View File

@ -1290,10 +1290,11 @@ checkConstantNoary _ _ = return ()
prop_checkBraceExpansionVars1 = verify checkBraceExpansionVars "echo {1..$n}" prop_checkBraceExpansionVars1 = verify checkBraceExpansionVars "echo {1..$n}"
prop_checkBraceExpansionVars2 = verifyNot checkBraceExpansionVars "echo {1,3,$n}" prop_checkBraceExpansionVars2 = verifyNot checkBraceExpansionVars "echo {1,3,$n}"
prop_checkBraceExpansionVars3 = verify checkBraceExpansionVars "eval echo DSC{0001..$n}.jpg" prop_checkBraceExpansionVars3 = verify checkBraceExpansionVars "eval echo DSC{0001..$n}.jpg"
prop_checkBraceExpansionVars4 = verify checkBraceExpansionVars "echo {$i..100}"
checkBraceExpansionVars params t@(T_BraceExpansion id list) = mapM_ check list checkBraceExpansionVars params t@(T_BraceExpansion id list) = mapM_ check list
where where
check element = check element =
when ("..$" `isInfixOf` toString element) $ when (any (`isInfixOf` toString element) ["$..", "..$"]) $
if isEvaled if isEvaled
then style id 2175 "Quote this invalid brace expansion since it should be passed literally to eval." then style id 2175 "Quote this invalid brace expansion since it should be passed literally to eval."
else warn id 2051 "Bash doesn't support variables in brace range expansions." else warn id 2051 "Bash doesn't support variables in brace range expansions."