From 7551a241ad11b2abc46f48e2790b0af716a29953 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Sat, 23 Apr 2016 16:00:56 -0700 Subject: [PATCH] Add missing warnings for {$i..10} similar to {1..$i} --- ShellCheck/Analytics.hs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index da53864..4fd72b5 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -1290,10 +1290,11 @@ checkConstantNoary _ _ = return () prop_checkBraceExpansionVars1 = verify checkBraceExpansionVars "echo {1..$n}" prop_checkBraceExpansionVars2 = verifyNot checkBraceExpansionVars "echo {1,3,$n}" prop_checkBraceExpansionVars3 = verify checkBraceExpansionVars "eval echo DSC{0001..$n}.jpg" +prop_checkBraceExpansionVars4 = verify checkBraceExpansionVars "echo {$i..100}" checkBraceExpansionVars params t@(T_BraceExpansion id list) = mapM_ check list where check element = - when ("..$" `isInfixOf` toString element) $ + when (any (`isInfixOf` toString element) ["$..", "..$"]) $ if isEvaled then style id 2175 "Quote this invalid brace expansion since it should be passed literally to eval." else warn id 2051 "Bash doesn't support variables in brace range expansions."