From 6aab109afb353efaa613c94bec88c2048c71e65a Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Tue, 23 Jul 2013 23:13:28 -0700 Subject: [PATCH] Fixed up some warning messages. --- ShellCheck/Analytics.hs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index 7eb27a5..3e0c4c8 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -471,9 +471,8 @@ checkForInLs t = try t case deadSimple x of ("ls":n) -> let warntype = if any ("-" `isPrefixOf`) n then warn else err in - warntype id $ "Iterate over globs (e.g. 'for f in */*.wav') whenever possible, as ls only works for simple, alphanumeric filenames." - ("find":_) -> warn id $ "Don't use 'for " ++ f ++ " in $(find ...). " - ++ "Use find -exec or a while read loop." + warntype id $ "Iterate over globs whenever possible (e.g. 'for f in */*.wav'), as for loops over ls will fail for filenames like 'my file*.txt'." + ("find":_) -> warn id $ "Use find -exec or a while read loop instead, as for loops over find will fail for filenames like 'my file*.txt'." _ -> return ()