Merge branch 'issue_1759_mapfile_proc_substition' of https://github.com/Gandalf-/shellcheck into Gandalf--issue_1759_mapfile_proc_substition

This commit is contained in:
Vidar Holen 2020-08-07 15:57:59 -07:00
commit 3ef1175566
2 changed files with 7 additions and 2 deletions

View File

@ -2228,6 +2228,7 @@ prop_checkUnassignedReferences37= verifyNotTree checkUnassignedReferences "var=h
prop_checkUnassignedReferences38= verifyTree (checkUnassignedReferences' True) "echo $VAR"
prop_checkUnassignedReferences39= verifyNotTree checkUnassignedReferences "builtin export var=4; echo $var"
prop_checkUnassignedReferences40= verifyNotTree checkUnassignedReferences ": ${foo=bar}"
prop_checkUnassignedReferences41= verifyNotTree checkUnassignedReferences "mapfile -t files <(cat); echo \"${files[@]}\""
checkUnassignedReferences = checkUnassignedReferences' False
checkUnassignedReferences' includeGlobals params t = warnings

View File

@ -659,13 +659,17 @@ getModifiedVariableCommand base@(T_SimpleCommand id cmdPrefix (T_NormalWord _ (T
-- mapfile has some curious syntax allowing flags plus 0..n variable names
-- where only the first non-option one is used if any. Here we cheat and
-- just get the last one, if it's a variable name.
-- just get the last one, if it's a variable name, and omitting process
-- substitions.
getMapfileArray base arguments = do
lastArg <- listToMaybe (reverse arguments)
lastArg <- listToMaybe (filter notProcSub $ reverse arguments)
name <- getLiteralString lastArg
guard $ isVariableName name
return (base, lastArg, name, DataArray SourceExternal)
notProcSub (T_NormalWord _ (T_ProcSub{} :_)) = False
notProcSub _ = True
-- get all the array variables used in read, e.g. read -a arr
getReadArrayVariables args =
map (getLiteralArray . snd)