This commit is contained in:
Louis Lam
2024-10-28 12:56:42 +08:00
parent 3a20e4726d
commit 60d65b18b7
3 changed files with 20 additions and 47 deletions

View File

@@ -1,20 +0,0 @@
const ClientMySQL2 = require("knex/lib/dialects/mysql2/index");
const KumaColumnCompiler = require("./schema/mysql2-columncompiler");
/**
* Fixed MySQL2 client class.
* - Fix: Default value for TEXT fields is not supported.
*/
class KumaMySQL2 extends ClientMySQL2 {
driverName = "mysql2";
/**
*
*/
columnCompiler() {
return new KumaColumnCompiler(this, ...arguments);
}
}
module.exports = KumaMySQL2;

View File

@@ -1,29 +1,21 @@
const ColumnCompilerMySQL = require("knex/lib/dialects/mysql/schema/mysql-columncompiler");
const { isObject } = require("knex/lib/util/is");
const { formatDefault } = require("knex/lib/formatter/formatterUtils");
const { log } = require("../../../../../../../src/util");
class KumaColumnCompiler extends ColumnCompilerMySQL {
/**
* Diff: Override defaultTo method to handle default value for TEXT fields
* Override defaultTo method to handle default value for TEXT fields
* @param {any} value Value
* @returns {string|void} Default value (Don't understand why it can return void or string, but it's the original code, lol)
*/
defaultTo(value) {
// MySQL defaults to null by default, but breaks down if you pass it explicitly
// Note that in MySQL versions up to 5.7, logic related to updating
// timestamps when no explicit value is passed is quite insane - https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_explicit_defaults_for_timestamp
if (value === null || value === undefined) {
return;
if (this.type === "text" && typeof value === "string") {
log.debug("defaultTo", `${this.args[0]}: ${this.type} ${value} ${typeof value}`);
// MySQL 8.0 is required and only if the value is written as an expression: https://dev.mysql.com/doc/refman/8.0/en/data-type-defaults.html
// MariaDB 10.2.1 is required: https://mariadb.com/kb/en/text/
return `default (${formatDefault(value, this.type, this.client)})`;
}
if ((this.type === "json" || this.type === "jsonb") && isObject(value)) {
// Default value for json will work only it is an expression
return `default ('${JSON.stringify(value)}')`;
}
const defaultVal = super.defaultTo.apply(this, arguments);
// louislam deleted: (this.type !== "blob" && this.type.indexOf("text") === -1)
// Other code is the same as the original code
// See: https://github.com/louislam/uptime-kuma/pull/5048#discussion_r1818076626
return defaultVal;
return super.defaultTo.apply(this, arguments);
}
}