7x31/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2025-08-08 15:18:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

move try/catch into main control flow and more from code review comments

Browse Source
This commit is contained in:
Humberto Evans
2024-02-13 17:27:59 -08:00
parent 4cdc8f344b
commit 5a9c3ad353
3 changed files with 27 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
server/notification-providers/heii-oncall.js
View File

@@ -17,19 +17,24 @@ class HeiiOnCall extends NotificationProvider {
payload["url"] = baseURL + getMonitorRelativeURL(monitorJSON.id);
}
if (!heartbeatJSON) {
// Testing or general notification like certificate expiry
payload["msg"] = msg;
return this.postNotification(notification, "alert", payload);
try {
if (!heartbeatJSON) {
// Testing or general notification like certificate expiry
payload["msg"] = msg;
return this.postNotification(notification, "alert", payload);
}
if (heartbeatJSON.status === DOWN) {
return this.postNotification(notification, "alert", payload);
}
if (heartbeatJSON.status === UP) {
return this.postNotification(notification, "resolve", payload);
}
} catch (error) {
this.throwGeneralAxiosError(error);
}
if (heartbeatJSON.status === DOWN) {
return this.postNotification(notification, "alert", payload);
}
if (heartbeatJSON.status === UP) {
return this.postNotification(notification, "resolve", payload);
}
}
/**
@@ -49,15 +54,11 @@ class HeiiOnCall extends NotificationProvider {
};
// Post to Heii On-Call Trigger https://heiioncall.com/docs#manual-triggers
try {
await axios.post(
`https://heiioncall.com/triggers/${notification.heiiOnCallTriggerId}/${action}`,
payload,
config
);
} catch (error) {
this.throwGeneralAxiosError(error);
}
await axios.post(
`https://heiioncall.com/triggers/${notification.heiiOnCallTriggerId}/${action}`,
payload,
config
);
return "Sent Successfully";
}