7x31/uptime-kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2025-08-09 18:34:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary func getKey

Browse Source 
Addresses:
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589856311
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589862733
This commit is contained in:
Matt Visnovsky
2024-05-06 09:49:36 -06:00
parent 86b997c664
commit 0384b34007
4 changed files with 5 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/monitor-types/snmp.js
View File

@@ -14,10 +14,7 @@ class SNMPMonitorType extends MonitorType {
port: monitor.port || "161",
retries: monitor.maxretries,
timeout: monitor.timeout * 1000,
// Resolve the net-snmp version identifier from monitor.snmpVersion using the `getKey` method (see utils.ts).
// If the specified version exists, use it; otherwise, default to SNMP version 2c.
version: getKey(snmp.Version, monitor.snmpVersion) || snmp.Version2c,
version: monitor.snmpVersion,
};
try {
@@ -40,8 +37,7 @@ class SNMPMonitorType extends MonitorType {
log.debug("monitor", `SNMP: Received varbinds (Type=${getKey(snmp.ObjectType, varbinds[0].type)}): ${varbinds[0].value}`);
// Verify if any varbinds were returned from the SNMP session or if the varbind type indicates a non-existent instance.
// The `getKey` method retrieves the key associated with the varbind type from the snmp.ObjectType object.
if (varbinds.length === 0 || getKey(snmp.ObjectType, varbinds[0].type) === "NoSuchInstance") {
if (varbinds.length === 0 || varbinds[0].type === snmp.ObjectType.NoSuchInstance) {
throw new Error(`No varbinds returned from SNMP session (OID: ${monitor.snmpOid})`);
// Varbinds succesfully returned