Close unclosed files (#735)

* Cose unclosed files

* Close additional unclosed file

* Dont use defer in loop

* Removed missed instances of defer in loop
This commit is contained in:
Callan Taylor
2019-11-13 17:28:23 +13:00
committed by Unknwon
parent f8e42d0001
commit c588ddea2d
5 changed files with 5 additions and 0 deletions

View File

@@ -16,6 +16,7 @@ func main() {
r = bufio.NewReader(r) r = bufio.NewReader(r)
r = new(bytes.Buffer) r = new(bytes.Buffer)
f, _ := os.Open("test.txt") f, _ := os.Open("test.txt")
defer f.Close()
r = bufio.NewReader(f) r = bufio.NewReader(f)
var s *bytes.Buffer = new(bytes.Buffer) var s *bytes.Buffer = new(bytes.Buffer)
r = s r = s

View File

@@ -31,5 +31,6 @@ func main() {
continue continue
} }
cat(bufio.NewReader(f)) cat(bufio.NewReader(f))
f.Close()
} }
} }

View File

@@ -17,6 +17,7 @@ func main() {
err) err)
os.Exit(1) os.Exit(1)
} }
defer fi.Close()
fz, err := gzip.NewReader(fi) fz, err := gzip.NewReader(fi)
if err != nil { if err != nil {
r = bufio.NewReader(fi) r = bufio.NewReader(fi)

View File

@@ -24,5 +24,6 @@ func main() {
for line, _, err := r.ReadLine(); err != io.EOF; line, _, err = r.ReadLine() { for line, _, err := r.ReadLine(); err != io.EOF; line, _, err = r.ReadLine() {
fmt.Printf("Lines: %v (error %v)\n", string(line), err) fmt.Printf("Lines: %v (error %v)\n", string(line), err)
} }
fin.Close()
} }
} }

View File

@@ -39,5 +39,6 @@ func main() {
continue continue
} }
cat(bufio.NewReader(f)) cat(bufio.NewReader(f))
f.Close()
} }
} }