7x31/the-way-to-go_ZH_CN
1
0
Fork 0
mirror of https://github.com/unknwon/the-way-to-go_ZH_CN.git synced 2025-08-12 03:55:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update min_interface.go (#543)

Browse Source 
Min(data Miner) 方法存在bug，原因是： 该方法的逻辑类似冒泡排序, 将Miner类型变量的集合挨个两两比对，但方法中仅将两变量的较小值取出（Less()方法），并赋值记录为min，最后返回，并没有进行“冒泡”这个swap操作。
因此补充了Swap()相关的接口和实现定义，并补充了Swap()在Min()方法中的逻辑。
This commit is contained in:
crackedcd
2018-09-10 18:34:37 +08:00
committed by 无闻
parent c28a3f0f68
commit 80b74f6d08
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
eBook/exercises/chapter_11/min_interface.go
View File

@@ -5,16 +5,19 @@ type Miner interface {
Len() int Len() int
ElemIx(ix int) interface{} ElemIx(ix int) interface{}
Less(i, j int) bool Less(i, j int) bool
Swap(i, j int)
} }
func Min(data Miner) interface{} { func Min(data Miner) interface{} {
j := 0 min := data.ElemIx(0)
for i := 1; i < data.Len(); i++ { for i := 1; i < data.Len(); i++ {
if data.Less(i, j) { if data.Less(i, i-1) {
j = i min = data.ElemIx(i)
} else {
data.Swap(i, i-1)
} }
} }
return data.ElemIx(j) return min
} }
type IntArray []int type IntArray []int
@@ -22,9 +25,11 @@ type IntArray []int
func (p IntArray) Len() int { return len(p) } func (p IntArray) Len() int { return len(p) }
func (p IntArray) ElemIx(ix int) interface{} { return p[ix] } func (p IntArray) ElemIx(ix int) interface{} { return p[ix] }
func (p IntArray) Less(i, j int) bool { return p[i] < p[j] } func (p IntArray) Less(i, j int) bool { return p[i] < p[j] }
func (p IntArray) Swap(i, j int) { p[i], p[j] = p[j], p[i] }
type StringArray []string type StringArray []string
func (p StringArray) Len() int { return len(p) } func (p StringArray) Len() int { return len(p) }
func (p StringArray) ElemIx(ix int) interface{} { return p[ix] } func (p StringArray) ElemIx(ix int) interface{} { return p[ix] }
func (p StringArray) Less(i, j int) bool { return p[i] < p[j] } func (p StringArray) Less(i, j int) bool { return p[i] < p[j] }
func (p StringArray) Swap(i, j int) { p[i], p[j] = p[j], p[i] }