7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-10-03 19:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid exporting empty env

Harshavardhana
2017-11-04 11:24:37 -07:00
parent c82895ac1d
commit e6abcc4d88
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
SC2155.md

@@ -9,8 +9,8 @@ export foo="$(mycmd)"
### Correct code: ### Correct code:
```sh ```sh
export foo
foo=$(mycmd) foo=$(mycmd)
export foo
``` ```
### Rationale: ### Rationale:
@@ -24,8 +24,8 @@ When first marked for export and assigned separately, the return value of the as
If you intend to ignore the return value of an assignment, you can either ignore this warning or use If you intend to ignore the return value of an assignment, you can either ignore this warning or use
```sh ```sh
export foo
foo=$(mycmd) || true foo=$(mycmd) || true
export foo
``` ```
Shellcheck does not warn about `export foo=bar` because `bar` is a literal and not a command substitution with an independent return value. It also does not warn about `local -r foo=$(cmd)`, where declaration and assignment must be in the same command. Shellcheck does not warn about `export foo=bar` because `bar` is a literal and not a command substitution with an independent return value. It also does not warn about `local -r foo=$(cmd)`, where declaration and assignment must be in the same command.