mirror of
https://github.com/koalaman/shellcheck.git
synced 2025-10-03 19:29:44 +08:00
Created SC2266 (markdown)
30
SC2266.md
Normal file
30
SC2266.md
Normal file
@@ -0,0 +1,30 @@
|
|||||||
|
## Use && for logical AND. Single & will background and return true.
|
||||||
|
|
||||||
|
### Problematic code:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
if [ "$1" = "--verbose" ] | [ "$1" = "-v" ]
|
||||||
|
then
|
||||||
|
verbose=1
|
||||||
|
fi
|
||||||
|
```
|
||||||
|
|
||||||
|
### Correct code:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
if [ "$1" = "--verbose" ] || [ "$1" = "-v" ]
|
||||||
|
then
|
||||||
|
verbose=1
|
||||||
|
fi
|
||||||
|
```
|
||||||
|
### Rationale:
|
||||||
|
|
||||||
|
ShellCheck found a `test` command followed by a `|`. This was undoubtedly intended as a logical OR (`||`).
|
||||||
|
|
||||||
|
### Exceptions:
|
||||||
|
|
||||||
|
None
|
||||||
|
|
||||||
|
### Related resources:
|
||||||
|
|
||||||
|
* Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!
|
Reference in New Issue
Block a user