7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-10-03 19:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

quick fix to reduce the number of logical negations, double meaning of "foo" and improve readability

Vasili Novikov
2022-01-11 08:23:05 +01:00
parent a555746471
commit a9ba1dafde
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
SC2155.md

@@ -50,9 +50,9 @@ foo=$(mycmd)
The exit status of the command is overridden by the exit status of the creation of the local variable. For example: The exit status of the command is overridden by the exit status of the creation of the local variable. For example:
```bash ```bash
$ f() { local foo=$(false) || echo foo; }; f $ f() { local foo=$(false) && echo "silent error happened"; }; f
$ f() { local foo; foo=$(false) || echo foo; }; f silent error happened
foo $ f() { local foo; foo=$(false) && echo "silent error happened"; }; f
``` ```
### Problematic code in the case of `readonly`: ### Problematic code in the case of `readonly`: