7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-10-03 19:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated SC2312 (markdown)

TinCanTech
2022-01-07 18:05:41 +00:00
parent baff7d4b10
commit a555746471
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
SC2312.md

@@ -18,6 +18,17 @@ dir="$(get_chroot_dir)"
cd "$dir/etc"
tar xf "$config"
```
### Correct code: (with correction)
```sh
set -e
dir="$(get_chroot_dir)"
[ -d "${dir}" ] || exit 1
cd "$dir/etc"
tar xf "$config"
```
### Rationale:
In the problematic example, the exit code for `get_chroot_dir` is ignored because it is used in a command substitution in the argument of another command.