mirror of
https://github.com/koalaman/shellcheck.git
synced 2025-10-03 19:29:44 +08:00
Created SC1124 (markdown)
48
SC1124.md
Normal file
48
SC1124.md
Normal file
@@ -0,0 +1,48 @@
|
||||
## ShellCheck directives are only valid in front of complete commands like 'case' statements, not individual case branches.
|
||||
|
||||
### Problematic code:
|
||||
|
||||
```sh
|
||||
case $? in
|
||||
0) echo "Success" ;;
|
||||
# shellcheck disable=2154
|
||||
*) echo "$cmd $flag returned failure" ;;
|
||||
esac
|
||||
|
||||
```
|
||||
|
||||
### Correct code:
|
||||
```sh
|
||||
# Applies to everything in the `case` statement
|
||||
# shellcheck disable=2154
|
||||
case $? in
|
||||
0) echo "Success" ;;
|
||||
*) echo "$cmd $flag returned failure" ;;
|
||||
esac
|
||||
```
|
||||
|
||||
or
|
||||
|
||||
```sh
|
||||
case $? in
|
||||
0) echo "Success" ;;
|
||||
*)
|
||||
# Applies to a single command within the `case`
|
||||
# shellcheck disable=2154
|
||||
echo "$cmd $flag returned failure"
|
||||
;;
|
||||
esac
|
||||
```
|
||||
|
||||
|
||||
### Rationale:
|
||||
|
||||
You appear to have put a directive before a branch in a case statement.
|
||||
|
||||
ShellCheck directives can not be scoped to individual branches of `case` statements, only to the entire `case`, or to individual commands within it. Please move the directive as appropriate.
|
||||
|
||||
(It is possible to apply directives to all commands within a `{ ..: }` command group, if you truly wish to apply a directive to multiple commands but not the full `case` statement.)
|
||||
|
||||
### Exceptions:
|
||||
|
||||
None.
|
Reference in New Issue
Block a user