7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-10-03 19:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated SC2060 (markdown)

Vidar Holen
2019-01-13 15:26:41 -08:00
parent dcba6f8866
commit 6f6b812423
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
SC2060.md

@@ -14,9 +14,9 @@ tr -cd '[:digit:]'
### Rationale: ### Rationale:
From the shell's point of view, unquoted `[:digit:]` is glob equivalent to `[dgit:]` that matches any single character filename from the group, such as `g` or `t`, in the current directory. From the shell's point of view, unquoted `[:digit:]` is a glob equivalent to `[dgit:]` that matches any single character filename from the group, such as `d` or `t`, in the current directory.
If someone starts learning D and creates a directory named `d` to hold the source code, the glob will be expanded and the script will end up executing `tr -cd d`, which is clearly unintended. If someone starts learning D and creates a directory named `d` to hold the source code, the glob will be expanded and the script will end up executing `tr -cd d` instead, which is clearly unintended.
Quoting the argument prevents this, and will pass it correctly as the literal string `[:digit:]` no matter which files exist in the current directory. Quoting the argument prevents this, and will pass it correctly as the literal string `[:digit:]` no matter which files exist in the current directory.