7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-10-03 19:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated SC1010 (markdown)

koalaman
2016-01-20 14:58:52 -08:00
parent b9b0bb7584
commit 657f12cc15
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
SC1010.md

@@ -2,16 +2,22 @@
### Problematic code: ### Problematic code:
```
for f in *; do echo "$f" done for f in *; do echo "$f" done
```
### Correct code: ### Correct code:
```
for f in *; do echo "$f"; done for f in *; do echo "$f"; done
```
### Rationale: ### Rationale:
`done` only works as a keyword when it's the first token of the command. If added after a command, it will just be the literal word "done". `done` only works as a keyword when it's the first token of the command. If added after a command, it will just be the literal word "done".
This is also true for other keywords like `then`.
### Exceptions ### Exceptions
If you're intentionally using `done` as a literal, you can quote it to make this clear to shellcheck (and also human readers), e.g. instead of `echo Task is done`, use `echo "Task is done"`. This makes no difference to the shell, but it will silence this warning. If you're intentionally using `done` as a literal, you can quote it to make this clear to shellcheck (and also human readers), e.g. instead of `echo Task is done`, use `echo "Task is done"`. This makes no difference to the shell, but it will silence this warning.