7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-10-03 19:29:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated SC2193 (markdown)

koalaman
2018-01-19 11:50:15 -08:00
parent 42cfcf764e
commit 5655e240fe
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
SC2193.md

@@ -3,17 +3,19 @@
### Problematic code:
```sh
[[ "{$var}" == "value" ]] # Swapped around $ and {
[[ "$(cmd1) | cmd2" == "42" ]] # Ended with ) too soon
[[ "$var " == *.png ]] # Trailing space
[ $var+1 == 5 ] # Unevaluated math
[ "{$var}" == "value" ] # Swapped around $ and {
[ "$(cmd1) | cmd2" == "42" ] # Ended with ) too soon
[[ "$var " == *.png ]] # Trailing space
```
### Correct code:
```sh
[[ "${var}" == "value" ]] # Correct variable expansion
[[ "$(cmd1 | cmd2)" == "42" ]] # Correct command substitution
[[ "$var" == *.png ]] # No trailing space
[ $((var+1)) == 5 ] # Evaluated math
[ "${var}" == "value" ] # Correct variable expansion
[ "$(cmd1 | cmd2)" == "42" ] # Correct command substitution
[[ "$var" == *.png ]] # No trailing space
```
### Rationale: