From 22e90bda5e1f9ffbe5e971bc80e33aca7fcfa38e Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Mon, 30 Aug 2021 11:35:37 -0700 Subject: [PATCH] Updated SC2233 (markdown) --- SC2233.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/SC2233.md b/SC2233.md index 4477320..fc6b4e7 100644 --- a/SC2233.md +++ b/SC2233.md @@ -1,4 +1,4 @@ -## Remove superfluous `(..)` around condition. +## Remove superfluous `(..)` around condition to avoid subshell overhead. ### Problematic code: @@ -36,7 +36,9 @@ Just delete the surrounding `(..)` since they serve no purpose and only slows th ### Exceptions: -None. +This issue only affects performance, not correctness, so it can be safely [[ignore]]d. + +If you are considering doing it to stylistically match C-like languages, please note that this is not conventional and that you'd probably recommend someone use `if (1 == 2)` over `if (system("[ 1 = 2 ]"))` in C no matter which language they're used to. ### Related resources: