From 175682046a85040728d16ea2c8834ba5b577b0e3 Mon Sep 17 00:00:00 2001 From: koalaman Date: Tue, 6 Sep 2016 20:20:01 -0700 Subject: [PATCH] Created SC2131 (markdown) --- SC2131.md | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 SC2131.md diff --git a/SC2131.md b/SC2131.md new file mode 100644 index 0000000..e87ddce --- /dev/null +++ b/SC2131.md @@ -0,0 +1,24 @@ +## This format string has 2 variables, but is passed 1 arguments. + +### Problematic code: + +```sh +printf "Hello %s, welcome to %s.\n" "$USER" +``` + +### Correct code: + +```sh +printf "Hello %s, welcome to %s.\n" "$USER" "$HOSTNAME" +``` +### Rationale: + +ShellCheck has noticed that you're using a `printf` format string with more `%s` variables than arguments to fill them. + +In the problematic example case, the last `%s` will just become an empty string each time. + +You should either remove the unused variables from the format string, or add enough arguments to fill them. + +### Exceptions: + +None. \ No newline at end of file