Created SC2027 (markdown)

koalaman
2014-05-07 21:07:35 -07:00
parent 13176a8b2e
commit 0298133f54

25
SC2027.md Normal file

@@ -0,0 +1,25 @@
## The surrounding quotes actually unquote this. Remove or escape them.
### Problematic code:
echo "You enter "$HOSTNAME". You can smell the wumpus." >> /etc/issue
### Correct code:
echo "You enter $HOSTNAME. You can smell the wumpus." >> /etc/issue
### Rationale:
Always quoting variables and command expansions is good practice, but blindly putting quotes left and right of them is not.
In this case, ShellCheck has noticed that the quotes around the expansion are unquoting it, because the left quote is terminating an existing double quoted string, while the right quote starts a new one:
echo "You enter "$HOSTNAME". You can smell the wumpus."
|----------| |---------------------------|
Quoted No quotes Quoted
If the quotes were supposed to be literal, they should be escaped. If the quotes were supposed to quote an expansion (as in the example), they should be removed because this is already a double quoted string.
### Contraindications
None.