a524929b69
Remove outdated test
2022-10-12 20:22:02 -07:00
81c2ecaccb
Remove true/false from SC2216/SC2217 ( fixes #2603 )
2022-10-11 19:40:29 -07:00
43aca62ca7
Fix false positive for SC2312 when using `time`
2022-10-10 03:33:38 +11:00
128351f5ef
Permit colon after exec
...
ShellCheck throws warning SC2093 when a script contains commands that could never be executed because they are after an `exec`. Command `:` does nothing, so add it to the list of commands that don’t trigger this warning.
2022-10-07 17:02:31 +01:00
d71d6ff294
Merge pull request #2581 from larryv/updatebashvars
...
Support more Bash internal variables
2022-09-25 11:24:45 -07:00
bd65b67578
Merge pull request #2586 from DoxasticFox/issue-2537
...
Suppress SC2311 with `set -o posix`
2022-09-25 11:04:30 -07:00
ef5f9a7af5
Add `mapfile` to harmless commands for SC2094
2022-09-25 03:04:20 +10:00
581981ba76
Suppress SC2311 with `set -o posix`
2022-09-24 07:20:48 +10:00
fcc473e27f
Include inherited env for DFA of leftover functions ( fixes #2560 )
2022-09-21 18:11:18 -07:00
0845b81183
Add READLINE_POINT to list of variables without spaces
2022-09-20 20:39:17 -04:00
966fb3e3dd
Recognize more Bash internal variables
...
- BASH_ARGV0, introduced in Bash 5.0
- BASH_COMPAT, 4.3
- BASH_LOADABLES_PATH, 4.4
- CHILD_MAX, 4.3
- EPOCHREALTIME, 5.0
- EPOCHSECONDS, 5.0
- EXECIGNORE, 4.4
- INSIDE_EMACS, 4.4
- PS0, 4.4
- READLINE_ARGUMENT, 5.2
- READLINE_MARK, 5.1
- SRANDOM, 5.1
Fixes #1780 and #2554 .
2022-09-20 20:39:10 -04:00
f28462b01c
Remove duplicate "COPROC" from internal vars list
2022-09-20 20:25:21 -04:00
ccab132b38
Reflow lists of internal shell variables
...
No functional changes; this just makes the next few commits cleaner.
2022-09-20 20:24:37 -04:00
4806719035
Handle variable assignments from `read` in CFG
2022-08-02 15:47:59 -07:00
0df9345142
Trace numerical status, use for SC2071 (ref #2541 )
2022-08-02 11:29:56 -07:00
77069f7445
Store postdominators as Array Node [Node] for a significant win
2022-07-31 15:43:24 -07:00
04db46381f
Use Data.Map.Strict instead for a ~15% parsing speedup
2022-07-29 09:02:45 -07:00
c76b8d9a32
Let annotations take effect earlier ( fixes #2534 )
2022-07-28 11:05:16 -07:00
d0dd81e1fa
Allow quoting values in directives ( fixes #2517 )
2022-07-28 08:56:44 -07:00
f440912279
Refactor to not generate Parameters twice
2022-07-28 08:26:56 -07:00
3ce310e939
Plug space leaks when processing multiple files
2022-07-27 14:42:57 -07:00
a30ac402eb
Don't use & for updates as result is unspecified
...
This fixes `Prelude.foldl1: empty list []` when script has `( exit )`
2022-07-27 11:30:26 -07:00
4a27c9a8d5
Fix overlap check
2022-07-26 15:33:25 -07:00
b5f5e6347d
Discard next rather than existing fixes when they overlap
2022-07-26 13:41:22 -07:00
c57e447c89
Correctly discard overlapping fixes in diff output ( fixes #2370 )
2022-07-26 10:16:12 -07:00
e9784fa9a7
Refine #2544 to not warn when $? postdominates [ ] ( fixes #2544 )
2022-07-25 12:00:59 -07:00
f1148b8b41
Include postdominators in CFGResult
2022-07-25 12:00:53 -07:00
982681fc05
Add unit test to ensure SC2321 does not trigger on associative arrays
2022-07-24 14:30:31 -07:00
52dac51cd4
SC2323: Warn about redundant parens in a[(x+1)] and $(( ((x)) )) (ref: #1666 )
2022-07-24 14:18:38 -07:00
30bb0e0093
SC2321: Warn about redundant $(()) in arr[$((i))]=x (ref: #1666 )
2022-07-24 14:18:38 -07:00
ea4e0091c7
Additionally pluralize 'arguments' in SC2183
2022-07-23 15:38:42 -07:00
81d9f7e640
Merge branch 'grammer_fix_sc2183' of https://github.com/ygeyzel/shellcheck into ygeyzel-grammer_fix_sc2183
2022-07-23 15:34:22 -07:00
69469c3603
Merge pull request #2543 from ygeyzel/SC2028-escape-chars
...
Add escape characters to SC2028: \a, \b, \e, \f, \v, \\, \', \OOO, \xHH
2022-07-23 15:30:00 -07:00
5cf6e01ce9
Warn when $? refers to echo or condition (ref #2541 )
2022-07-23 09:39:26 -07:00
f7857028f7
Add escape characters to SC2028: \a, \b, \e, \f, \v, \\, \', \OOO, \xHH
2022-07-23 19:28:37 +03:00
b261ec24f9
Include exit codes in DFA (ref #2541 )
2022-07-23 08:50:19 -07:00
819470fa1d
Omit SC3021 about `>& file` unless definitely non-numeric ( fixes #2520 )
2022-07-22 17:06:24 -07:00
2f28847b08
Normalize spaces around = in unit tests
2022-07-22 16:35:14 -07:00
e47480e93a
Also emit SC2004 for array indices ( fixes #1666 )
2022-07-22 16:29:52 -07:00
9caeec104b
SC2318: Warn about backreferencing in `declare x=1 y=$x` ( fixes #1653 )
2022-07-22 12:40:59 -07:00
95b3cbf071
Qualify Data.Map as M instead of tedious Map
2022-07-22 11:11:09 -07:00
e7f05d662a
In addition to start/end, track sets of nodes belonging to tokens
2022-07-22 10:29:19 -07:00
3ee4419ef4
Suppress SC2086 for variables declared -i (ref #2541 )
2022-07-22 08:53:27 -07:00
da4885a71d
Use DFA for SC2086
2022-07-20 08:08:44 -07:00
642ad86125
Add SC2317 warning about unreachable commands
2022-07-20 08:08:41 -07:00
f77a545282
Control Flow Graph / Data Flow Analysis support
2022-07-20 08:08:24 -07:00
a4042f7523
Parse &&/|| as left-associative
2022-07-20 08:08:24 -07:00
363c0633e0
When reparsing array indices, do it recursively
2022-07-20 08:08:24 -07:00
7ceb1f1519
SC2183 grammer fix: 'variable' instead of 'variables' if only one variable
2022-07-17 21:46:42 +03:00
fd595d1058
Only trigger SC2316 on unquoted words.
2022-05-06 10:06:12 -07:00
2821552688
Fix bug in 2126 when using after/before flags with grep
...
Using `--after-context`/`-A` or `--before-context`/`-B` would give a warning
recommending the user to use `grep -c`, even though that would give a different
result than using `grep | wc -l`:
```fundamental
$ echo -e "1\n2\n3" | grep -cA 3 1
1
$ echo -e "1\n2\n3" | grep -A 3 1 | wc -l
3
```
2022-05-06 09:17:23 -07:00
fa15c0a454
add SC2316: error on multiple declarations like 'readonly local'
2022-05-05 16:19:07 -07:00
88cdb4e2c9
Warn about spaces around = in alias ( fixes #2442 )
2022-02-03 19:23:46 -08:00
ade2bf7b87
Allow parsing [[ x = ["$y"] ]] ( fixes #2165 )
2022-01-09 16:50:50 -08:00
e6e558946c
Improve decoding of single quoted literals ( fixes #2418 )
2021-12-21 14:30:39 -08:00
dd626686c4
Merge pull request #2375 from scop/spelling
...
Comment spelling fixes
2021-12-05 14:27:08 -08:00
d7971dafd1
Minor formatting fixes
2021-12-04 17:37:12 -08:00
9092080a84
bats: Add check for useless negation (SC2314/15)
2021-11-15 12:01:12 +01:00
499c99372e
Rewrite SC2032 warning and mention line number ( fixes #2353 )
2021-11-14 21:34:21 -08:00
d9a9d5db86
Mark prefix/postfix inc/dec as integers ( fixes #2376 )
2021-11-14 16:39:32 -08:00
c5de58ae84
Comment spelling fixes
2021-11-13 12:50:53 +02:00
3b6972fbf1
Update copyright years
2021-11-06 19:07:34 -07:00
8db220ae43
Include `local -r` in check-extra-masked-returns ( fixes #2362 )
2021-11-06 15:37:59 -07:00
efd49e486f
Consider all forms of TA_Assignment to remove spaces ( fixes #2364 )
2021-10-30 17:47:30 -07:00
0dd5c67bdf
Warn about [^..] in Dash ( fixes #2361 )
2021-10-21 21:00:39 -07:00
788aee1b7c
Treat typeset similar to declare ( fixes #2354 )
2021-10-15 14:41:48 -07:00
c3aaa27540
Skip SC2214 if variable is modified in loop ( fixes #2351 )
2021-10-09 12:13:41 -07:00
3aedda766d
For `while getopts; do case ..` checks, make sure variable matches
2021-10-09 11:40:52 -07:00
205ba429b3
Warn about `read foo[i]` expanding as glob ( fixes #2345 )
2021-10-07 18:50:44 -07:00
38251abe26
Add suggestion level in text for TTY output ( fixes #2339 )
2021-10-07 17:14:41 -07:00
23cddb037e
Merge pull request #2320 from DoxasticFox/set-e-proc-sub
...
Add extra checks for masked return codes
2021-10-02 12:52:59 -07:00
093df8cb24
Add extra checks for masked return codes
2021-10-02 01:36:40 +10:00
fac97a5301
Don't emit SC2140 when trapped string is /, = or : ( fixes #2334 )
2021-09-25 20:23:58 -07:00
ad92cb4112
Disable UUOC for cat with unquoted variable ( fixes #2333 )
2021-09-25 19:46:27 -07:00
db4701d8b5
Add a `setgitversion` script to update the version string with git
2021-09-18 20:46:46 -07:00
e7df718724
Strip lines containing "STRIP" from ./striptests
2021-09-18 20:43:42 -07:00
b044f5b23a
Don't trigger SC2140 on ${x+"a" "b"} ( fixes #2265 )
2021-09-18 18:59:42 -07:00
8012f6761d
Suppress SC2094 when both are input redirections ( fixes #2325 )
2021-09-18 18:00:15 -07:00
2536507060
Remove SC1004 ( fixes #2326 )
2021-09-18 17:43:55 -07:00
09aa15c9b7
Allow `disable=all` to disable all warnings ( fixes #2323 )
2021-09-18 12:50:01 -07:00
9a54e91195
Merge pull request #2318 from FabianWolff/grep-lL-wc-l
...
Do not suggest `grep -c` as a replacement for `grep -l/-L | wc -l`
2021-09-16 19:40:40 -07:00
4e703e5c61
Allow specifying external-sources=true in shellcheckrc ( fixes #1818 )
2021-09-15 18:02:37 -07:00
64733cc110
Merge pull request #2303 from DoxasticFox/set-e-functions
...
Show info about `set -e` suppression during function calls
2021-09-04 17:06:24 -04:00
dc9032fca5
Show info about `set -e` suppression during function calls
2021-09-05 04:23:25 +10:00
40216487d6
Do not suggest `grep -c` as a replacement for `grep -l/-L | wc -l`
2021-09-02 17:47:06 +02:00
747bd8fd6a
Warn about strings for numerical operators in [[ ]] ( fixes #2312 )
2021-08-30 19:50:00 -07:00
f5fd9c2fed
Improve warnings about unnecessary subshells ( fixes #2169 )
2021-08-30 10:56:55 -07:00
081f7eba24
Fix parsing of [$var] ( fixes #2309 )
2021-08-26 23:05:14 -07:00
81b7ee5598
Don't warn about unused variables starting with _ ( fixes #1498 )
2021-08-26 19:40:21 -07:00
c85ce2cb06
Add `rg` to list of commands ignored for SC2016 ( fixes #2209 )
2021-08-26 18:50:40 -07:00
5b6fd60279
Improve warnings for expr ( fixes #2033 )
2021-08-22 21:12:58 -07:00
da7b28213e
Recognize wait -p as assigning a variable ( fixes #2179 )
2021-08-17 21:53:27 -07:00
c61fc7546e
Don't warn about variables guarded with :+ ( fixes #2296 )
2021-08-17 16:20:32 -07:00
8c0bf8d41f
Warn about looping over array values and using them as keys
2021-08-17 12:51:27 -07:00
bb0a571a1e
Improve warnings for bad parameter expansion ( fixes #2297 )
2021-08-16 21:02:20 -07:00
fed4a048bc
Suppress SC2167 when name is "_" ( fixes #2298 )
2021-08-13 23:11:20 -07:00
e5745568e8
Extend warnings about spaces around = to 'let'
2021-08-08 15:48:50 -07:00
cf8066c07c
SC2295 Warn about unquoted variables in PE patterns ( fixes #2290 )
2021-08-03 13:02:53 -07:00
a44f3edb14
Warn about eval'ing arrays
2021-07-30 18:46:19 -07:00
e33146d530
Avoid trigger SC2181 on composite $? checks ( fixes #1167 )
2021-07-29 20:51:19 -07:00
Vidar Holen
Christian Nassif-Haynes
Peter Oliver
Vidar Holen
Lawrence Velázquez
ygeyzel
Rune Juhl Jacobsen
Patrick Xia
Martin Schulze
Ville Skyttä
Fabian Wolff