ea24e25efd
Use Map.member instead of isJust and Map.lookup
2020-02-09 23:18:09 -05:00
8f0448133c
Use isNothing instead of reimplementing it
2020-02-09 23:18:08 -05:00
7fc9496320
Use forM_ instead of reimplementing it
2020-02-09 23:18:08 -05:00
962fad038c
Avoid a zip that breaks fusion
2020-02-09 23:18:08 -05:00
a223a7a5a5
Remove unnecessary fromMaybes
2020-02-09 23:18:08 -05:00
8e9290badb
Do toLower earlier
2020-02-09 23:17:53 -05:00
292b0840d9
Simplify a double negative
2020-02-09 23:17:53 -05:00
43c24cf79c
Use Map.! instead of reimplementing it
2020-02-09 23:17:53 -05:00
21ad4196db
Simplify findFunction
2020-02-09 23:17:53 -05:00
172aa7c4fc
Avoid unnecessary use of when and unless
2020-02-09 23:17:53 -05:00
c290eace54
Inline an uncurry
2020-02-09 23:17:53 -05:00
a6efd02807
Simplify <> for SpaceStatus
2020-02-09 23:17:53 -05:00
057cc714b3
Simplify matchToken
2020-02-09 23:17:52 -05:00
0e00249eae
Use void instead of do and return ()
2020-02-09 23:17:52 -05:00
0ca50159ec
Use head instead of reimplementing it
...
Normally I wouldn't use head, but this code is partial anyway.
2020-02-09 23:17:52 -05:00
7e6a556ef1
Get rid of potentially
...
This already exists as sequence_.
2020-02-09 23:17:52 -05:00
4bfe6496d9
Simplify check and checkTranslatedStringVariable
...
Avoid the "potentially" and "Maybe" business, and just use regular guards.
2020-02-09 23:17:52 -05:00
ffbbfcfe25
Use mapM_ and sequence_ instead of reimplementing them
2020-02-09 23:17:52 -05:00
cc424bac11
Use find instead of take 1 and filter
2020-02-09 23:17:52 -05:00
cb01cbf7eb
Use mapM instead of implementing a slower version of it
2020-02-09 23:17:52 -05:00
1e32139f66
Replace mapMaybe and concatMap with list comprehensions
2020-02-09 23:17:52 -05:00
9d604ae732
Merge pull request #1822 from yetamrra/arrayindex
...
SC2191: Tighten index checks
2020-02-08 10:48:07 -08:00
1ca0b72329
Merge pull request #1816 from josephcsible/cleanups
...
Various cleanups and refactorings
2020-02-08 10:38:27 -08:00
474b23d6e7
SC2191: Tighten index checks
...
When adding a value containing an equals sign to an indexed array, the
left side is treated as an index if it looks like [N]=val and N is
numeric. SC2191 currently warns about anything that looks like key=val
even though non-numeric values of key will never be treated as an index.
This causes spurious warnings for the common pattern of building up
program arguments in an array, such as:
args=(
--dry-run
--in="${my_var}"
--out=/some/path
-f
)
/bin/program "${args[@]}"
Since only numeric expressions can be a valid index for an indexed
array, only emit SC2191 if the left side of a literal string containing
an equals looks numeric. Other more complicated constructs should still
warn because shellcheck doesn't know if they may evaluate to a numeric
result. Associative arrays still warn because a non-numeric left side
is a valid subscript.
2020-02-05 16:50:32 -07:00
e820a5642b
Adjust a pattern to get rid of a fromJust
2020-02-02 00:40:22 -05:00
6595e14d25
Adjust a pattern to avoid tail
2020-02-02 00:24:24 -05:00
115ef29079
Use pattern matching instead of head
2020-02-02 00:16:59 -05:00
c29b6afa56
Use null instead of comparing with empty lists
2020-02-01 23:04:04 -05:00
f25b8bd03a
Use gets instead of fmapping the result of get
2020-02-01 22:50:20 -05:00
28978a8b65
Use maybe instead of fromMaybe and fmap
2020-02-01 22:50:17 -05:00
f5c6771016
Use find instead of listToMaybe and filter
2020-02-01 22:50:16 -05:00
3449e6be21
Get rid of our getOpt, as it already exists as lookup
2020-02-01 22:50:13 -05:00
2e52c2b56a
Use notElem instead of not on the result of elem
2020-02-01 22:50:11 -05:00
1696296c0a
Make SC2141 trigger more broadly
2020-02-01 16:51:40 -08:00
cbcca528ae
Merge branch 'iss1724-builtin-support' of https://github.com/jabberabbe/shellcheck into jabberabbe-iss1724-builtin-support
2019-12-21 18:13:07 -08:00
9f578f41a1
Explicitly add 'mappend' for old GHC versions
2019-11-16 11:16:15 -08:00
f44624a9c0
Hide <> from Writer to not conflict with Semigroup
2019-11-14 20:02:25 -08:00
c75bbcbd60
Include missing Semigroup import
2019-11-13 22:10:27 -08:00
4a63a3a8bd
For SC2256, make sure the complete string is a variable name
2019-11-13 21:48:01 -08:00
2341a4c683
SC2256: Check for translated strings matching known variables
...
SC2247 already warns about translated strings that look like $"(foo)" or
$"{foo}". Since typical use of translated strings is to translate whole
messages, a string like $"foo" is likely to be a similar mistake if foo
is the name of an existing variable. Conversely, a string like
$"foo bar" is potentially meant to be a message id even if foo is a
known variable.
Add a warning for the $"foo" case, but make it separate from the
existing warning so that projects that reuse variable names as their
message ids can separately disable the new warning.
2019-11-13 16:41:16 -07:00
5962b01816
Correctly handle empty variables for SC2086 ( fixes #1722 )
2019-11-03 12:46:25 -08:00
0e0de94045
Fix issue #1724
...
(bash: missing support for 'builtin' keyword)
Now shellcheck looks for the arguments to 'builtin' to determine
read/written variables. A change in the parser makes sure that
assignments are parsed correctly in commands that start with 'builtin'.
2019-11-01 13:49:17 +01:00
f042b0ebd1
Merge branch 'iboss-ptk-read-t-0'
2019-10-12 20:55:32 -07:00
764fdcb260
Move failing test to correct check
2019-10-12 20:50:55 -07:00
7473d4a743
Make `read -t 0` test more forgiving towards other flags
2019-10-12 20:45:36 -07:00
91abd979f2
Merge branch 'read-t-0' of https://github.com/iboss-ptk/shellcheck into iboss-ptk-read-t-0
2019-10-12 20:23:13 -07:00
afea62de4e
Suggest using `$((..))` in `[ 2*3 -eq 6 ]` ( fixes #1641 )
2019-10-12 19:55:20 -07:00
7fb399528c
Allow `read -t 0` to not require -r flag
...
since it has specific purpose for checking only
2019-10-02 22:34:43 +07:00
de9ab4e6ef
Fix glob range duplicate warning in [!!] ( fixes #1706 )
2019-09-28 14:03:11 -07:00
e01c470598
Suggest quoting case patterns, as for SC2053 ( fixes #1682 )
2019-09-08 20:08:43 -07:00
Joseph C. Sible
Vidar Holen
Benjamin Gordon
Tito Sacchi
Supanat Pothivarakorn