d02a9bbcce
Account for &&/||/{}/() in SC2233&co ( fixes #1320 ).
2018-08-26 17:36:10 -07:00
932e2b3538
Merge branch 'opqaque-interface' of https://github.com/ngzhian/shellcheck into ngzhian-opqaque-interface
2018-08-18 20:32:27 -07:00
3fe11927bb
SQUASH: --severity specifies *minimum* severity to be handled
...
Signed-off-by: Martin Schwenke <martin@meltin.net>
2018-08-18 20:05:56 -07:00
b16da4b242
Add command-line option -S/--severity
...
Specifies the maximum severity of errors to handle. For example,
specifying "-S warning" means that errors of severity "info" and
"style" are ignored.
Signed-off-by: Martin Schwenke <martin@meltin.net>
2018-08-18 20:05:56 -07:00
c8e0797350
Make data in Interface more opaque
2018-08-17 22:10:18 -07:00
15aaacf715
Add test for parsing bitwise not
2018-08-15 18:30:10 -07:00
5ef4229f61
Modernize SC2028 echo escape test
2018-08-07 19:31:28 -07:00
8be76b13b9
Use regex to match special flags for printf
...
Fixes #1310
2018-08-05 22:45:24 -07:00
581be5878b
Suggest 'cat' when piping/redirecting to echo ( fixes #1292 )
2018-07-28 17:38:53 -07:00
0f835a5a2c
Don't trigger SC2222 for fallthrough case branches ( fixes #1044 )
2018-07-28 12:30:06 -07:00
4b0a35d4c9
Merge pull request #1302 from pjeby/fix949
...
Fix #949 (failing on @ in function names)
2018-07-26 21:07:48 -07:00
51e0c1be62
Use three instead of two dots in 2006 message
2018-07-26 19:59:42 -07:00
d8a32da07f
Retire SC1117 (unknown quoted escapes) due to noise
2018-07-26 19:23:53 -07:00
0d1a34a291
Fix #949 (failing on @ in function names)
...
'@' was previously mentioned in 5005dc0fa1fix #909 , but was not included
in the actual change at that time.
2018-07-23 16:18:35 -04:00
5005dc0fa1
Allow directive/-s to override shebang blacklist ( fixes #974 )
2018-07-22 12:43:51 -07:00
b8ee7436e5
Add a test for 03ce3b15
2018-07-21 13:51:21 -07:00
da8e450386
Realign =s
2018-07-21 13:51:08 -07:00
03ce3b15b6
Fix false positive when indexing into array in cond
...
Fixes #1268
2018-07-18 22:31:58 -07:00
f91b5bc270
Merge pull request #1256 from ngzhian/mv-stdin
...
Do not warn on mv -i (fixes #1251 )
2018-06-24 11:47:53 -07:00
b01f1128c7
Make SC1012 "printf '\t'" suggestion use single quotes
2018-06-24 11:47:00 -07:00
75fb4da387
Don't warn about tr '[=e=]' equivalence classes
2018-06-23 16:55:35 -07:00
6869c2fa18
Merge pull request #1261 from ngzhian/1188
...
Do not warn find --help (fixes #1188 )
2018-06-23 16:07:23 -07:00
868a7be33e
Improve spans for some warnings
2018-06-17 19:19:18 -07:00
7138abff4b
Expose (some) span information in TTY output
2018-06-17 17:44:31 -07:00
9d3e79b576
Require all Ids to be constructed with a span
2018-06-16 17:33:08 -07:00
402e635f86
Warn about & followed by letters, e.g. http://foo/?a=b&c=d
2018-06-16 12:30:19 -07:00
91cbcddd9d
Do not warn find --help ( fixes #1188 )
2018-06-14 22:40:26 -07:00
0cc45447d3
Do not warn on mv -i ( fixes #1251 )
2018-06-13 21:39:37 -07:00
32a53f21b5
Merge pull request #1239 from ngzhian/end_column
...
End column
2018-06-13 19:29:55 -07:00
7adeaccd11
Check popd flags for -n ( fixes #1252 )
2018-06-12 22:53:41 -07:00
b63483d44c
Remove unused import
2018-06-12 22:50:02 -07:00
4111ce8fde
Make end pos non-optional
2018-06-12 22:39:06 -07:00
b9a9eb2529
Change getNextId to create a zero width span at new id
2018-06-12 22:17:35 -07:00
e717802de1
Change usage of endPosOfStartId to startSpan and endSpan
2018-06-12 22:11:11 -07:00
1699c9e9ba
Add api to begin and end a span of source code
2018-06-12 21:56:53 -07:00
bfc32200e2
Correctly consider $'..' a literal ( fixes #1242 )
2018-06-10 20:23:10 -07:00
8ff35fb4af
Add end pos to readSingleQuoted
2018-06-07 23:09:59 -07:00
29e8c0a16e
Add end pos to readDollarBraced
2018-06-07 22:25:16 -07:00
3848788c2d
Add end pos to readDollarVariable
2018-06-07 21:55:41 -07:00
0c459ae2cb
Add function to set end pos of start id
2018-06-07 21:55:41 -07:00
e496b413bd
Remove usage of withNextId
2018-06-07 21:55:41 -07:00
48ac654a93
Merge end pos map into start pos map
2018-06-07 21:55:41 -07:00
4470fe715c
Support emitting a correct end column on SC2086
...
This does the necessary work to emit end columns on AST analyses. SC2086
is made to emit a correct end column as an illustrative example.
For example:
```
$ shellcheck -s bash -f json /dev/stdin <<< 'echo $1'
[{"file":"/dev/stdin","line":1,"endLine":1,"column":6,"endColumn":8,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."}]
```
This change deprecates the parser's getNextId and getNextIdAt, replacing
it with a new withNextId function. This function has the type signature:
withNextId :: Monad m => ParsecT s UserState (SCBase m) (Id -> b) -> ParsecT s UserState (SCBase m) b
Specifically, it should be used to wrap read* functions and will pass in
a newly generated Id which should be used to represent that node.
Sub-parsers will need their own call to withNextId in order to get a
unique Id.
In doing this, withNextId can now track both the entry and exit position
of every read* parser which uses it, enabling the tracking of end
columns throughout the application.
2018-06-07 21:55:41 -07:00
b5e5d249c4
Merge pull request #1237 from ngzhian/1234
...
Check if builtin cd is called
2018-05-27 18:34:18 -07:00
efffc6150b
Warn about string operations on $@/$* ( fixes #1236 )
2018-05-27 12:53:01 -07:00
cb4a0c0250
Check if builtin cd is called
...
Fixes #1234
2018-05-27 11:42:37 -07:00
135cf5932f
Parse here docs as per spec ( fixes #1050 )
2018-05-26 21:01:18 -07:00
467dfe07b6
Add a unit test and separate ids for 884eff0c
2018-05-23 19:51:36 -07:00
d140388bea
Merge pull request #1232 from ngzhian/source-x
...
Add T_SourceCommand to wrap source commands and sourced code
2018-05-23 19:41:55 -07:00
884eff0c36
Add T_SourceCommand to wrap source commands and sourced code
...
Fixes #1181
2018-05-22 22:43:26 -07:00
Vidar Holen
Martin Schwenke
Ng Zhi An
Vidar Holen
PJ Eby
Russell Harmon