Commit Graph

1967 Commits

Author SHA1 Message Date
Vidar Holen db11e2f663
Merge pull request #1872 from josephcsible/checkforinquoted
Simplify checkForInQuoted
2020-03-31 19:10:25 -07:00
Vidar Holen aac1d05a7e
Merge pull request #1893 from josephcsible/pattern-synonyms
Fix #1892: Use pattern synonyms to clean up AST
2020-03-31 18:13:22 -07:00
Vidar Holen 67f0dc4fd5 Update distro tests to support newer Cabal 2020-03-30 22:28:56 -07:00
Joseph C. Sible 8cf037fe5e Fix #1892: Use pattern synonyms to clean up AST 2020-03-28 18:38:07 -04:00
Artur Klauser 615063a9c3
Don't try to deploy docker images on PR runs
For security reasons, PR runs don't have access to Travis secrets. However,
Docker deployment depends on the secret DOCKER_PASSWORD. Thus we shouldn't try
Docker deployment when running PRs since it will fail for lack of access.
2020-03-28 09:27:17 +01:00
Vidar Holen 37e78141bd Stop deploying artifacts to GCS 2020-03-26 17:02:08 -07:00
Joseph C. Sible 9f833770b0
Mark that base >= 4.8.0.0 is required
We've actually already required base >= 4.8.0.0 since commit a8376a0 (in which we first used `<$>` without an import, which wasn't in the Prelude prior to this version). Since then, we've also made use of other more substantial features that de-facto require base >= 4.8.0.0 since they require GHC 7.10, such as `DeriveAnyClass`.
2020-03-19 21:31:10 -04:00
Vidar Holen 7963eeab9d Include shebang in AST traversal (fixes #1858) 2020-03-16 21:36:41 -07:00
girst 7a5e261d03 recognize `: ${parameter=word}` as assignment 2020-03-16 23:04:54 +01:00
Joseph C. Sible 9d5363377e Simplify checkWhileReadPitfalls
* Clean up usage of not
* Use a case match instead of sequence_ and a do block
2020-03-16 00:14:22 -04:00
Joseph C. Sible 86d470c74f Simplify checkForInQuoted
* Avoid some unnecessary fmaps
* Reuse an identical pattern-match for two guards
* Apply De Morgan's law
* Use forM_ to avoid an unnecessary where
2020-03-15 16:05:55 -04:00
Vidar Holen acee69676b Try to make TravisCI not fail on deployment of Docker stage 2020-03-15 12:54:54 -07:00
Vidar Holen a57f6d2886 Improve detection of for loops with single values 2020-03-15 11:30:56 -07:00
Vidar Holen d28c8f883f
Merge pull request #1865 from josephcsible/patch-1
Use headOrDefault instead of fromMaybe and listToMaybe
2020-03-14 21:21:13 -07:00
Vidar Holen c43b19f897 Make SC2095 (ssh in while read loops) more robust and suggest fixes 2020-03-14 21:15:47 -07:00
Joseph C. Sible 45a67e7c64
Use headOrDefault instead of fromMaybe and listToMaybe 2020-03-10 13:27:52 -04:00
Vidar Holen 68a03e05e5 Refer to GitHub rather than GCS for release builds 2020-03-08 17:41:46 -07:00
Vidar Holen 014a66f3f6 Fix TravisCI condition 2020-03-07 18:06:14 -08:00
Vidar Holen fee13732a4
Merge pull request #1862 from austin987/sc2148-shell-directive
src/ShellCheck/Analytics.hs: suggest using a shell directive for SC2148
2020-03-07 17:43:44 -08:00
Austin English 741d499b3d src/ShellCheck/Analytics.hs: suggest using a shell directive for SC2148 2020-03-07 19:23:35 -06:00
Vidar Holen 9b66bc2f13 Upload to assets to GitHub 2020-03-07 17:13:01 -08:00
Luke Davis 00574dd1fc
Add conda install instructions 2020-03-03 13:23:24 -07:00
Vidar Holen 7b998239af SC2257: Warn when changing arithmetic variables in redirections 2020-02-17 18:16:57 -08:00
Vidar Holen 4c9210af79 Inspect 'alias' commands for referenced variables (Fixes #1832) 2020-02-17 14:20:21 -08:00
Vidar Holen a75219e525 Remove unused instance Ord Replacement (fixes #1829) 2020-02-17 12:44:38 -08:00
Vidar Holen 99d6df8a08 Bump SC1102/SC1105 about ambiguous `$((` to Error (fixes #1836) 2020-02-17 12:27:24 -08:00
Vidar Holen 106f321cf0 Parse keywords with case sensitivity (fixes #1809) 2020-02-17 11:13:29 -08:00
Vidar Holen 1da0becb0f Rename 'Test' stage 2020-02-15 19:24:16 -08:00
Vidar Holen 472579052b Don't try to deploy on PRs 2020-02-15 16:56:20 -08:00
Vidar Holen c735bbf30a
Merge pull request #1831 from josephcsible/checkfindnameglob
Improve checkFindNameGlob
2020-02-15 16:49:22 -08:00
Joseph C. Sible eecd003e2d Optimize patterns in checkFindNameGlob
1. Instead of pattern-matching the same list multiple times, do it only
   once and then pass the pieces separately.
2. Don't reconstruct an object equivalent to one we just deconstructed.
2020-02-11 01:04:49 -05:00
Joseph C. Sible 440d0038aa Remove a partial pattern match equivalent to fromJust from checkFindNameGlob 2020-02-11 01:03:10 -05:00
Vidar Holen 12bc7a750c
Merge pull request #1785 from ArturKlauser/multi-arch-docker
Add multi-architecture Docker image build
2020-02-10 20:28:33 -08:00
Vidar Holen c2d67c15f8
Merge pull request #1802 from szydell/master
SC2016, repair false error for M language parser
2020-02-10 18:25:28 -08:00
Vidar Holen 6043deb8f2
Merge pull request #1824 from josephcsible/patch-1
Simplify literalEquals
2020-02-10 18:20:05 -08:00
Vidar Holen 83d329c8da
Merge pull request #1825 from josephcsible/nofilterm
Use findM instead of filterM
2020-02-10 18:10:15 -08:00
Vidar Holen d0beac6d0b
Merge pull request #1826 from josephcsible/nofromjust
Use the Identity monad to avoid unnecessary uses of fromJust
2020-02-10 18:05:36 -08:00
Vidar Holen b88b253cad
Merge pull request #1827 from josephcsible/nofromjust2
Remove more unnecessary uses of fromJust
2020-02-10 18:01:38 -08:00
Vidar Holen a8f9f25ec9
Merge pull request #1828 from josephcsible/cleanups
Another round of cleanups/refactoring
2020-02-10 18:01:12 -08:00
Joseph C. Sible 85c49a8af9 Simplify mockedSystemInterface 2020-02-09 23:50:48 -05:00
Joseph C. Sible 42abcb7ae2 Simplify shellFromFilename 2020-02-09 23:18:09 -05:00
Joseph C. Sible d5c5128115 Use isJust instead of reimplementing it 2020-02-09 23:18:09 -05:00
Joseph C. Sible 6d06103cab Remove unnecessary uses of head 2020-02-09 23:18:09 -05:00
Joseph C. Sible c95914f9b3 Simplify determineShell 2020-02-09 23:18:09 -05:00
Joseph C. Sible ea24e25efd Use Map.member instead of isJust and Map.lookup 2020-02-09 23:18:09 -05:00
Joseph C. Sible 8f0448133c Use isNothing instead of reimplementing it 2020-02-09 23:18:08 -05:00
Joseph C. Sible 7fc9496320 Use forM_ instead of reimplementing it 2020-02-09 23:18:08 -05:00
Joseph C. Sible 962fad038c Avoid a zip that breaks fusion 2020-02-09 23:18:08 -05:00
Joseph C. Sible a223a7a5a5 Remove unnecessary fromMaybes 2020-02-09 23:18:08 -05:00
Joseph C. Sible 8e9290badb Do toLower earlier 2020-02-09 23:17:53 -05:00