Vidar Holen
baab5b53e0
Use TravisCI workspaces
2020-07-01 21:21:38 -07:00
Vidar Holen
210cdcd01a
Treat $x/ or $(x)/ as ./ when finding sourced files ( fixes #1998 )
2020-06-28 17:24:07 -07:00
Vidar Holen
1b884a17ea
Merge pull request #2002 from stdedos/patch-1
...
Autolink https://www.shellcheck.net/
2020-06-28 16:05:24 -07:00
Vidar Holen
b52f58473d
Merge pull request #1999 from aureliojargas/patch-1
...
SC1102: Fix typo in error message: substition
2020-06-28 16:04:56 -07:00
Vidar Holen
376e78b631
Merge branch 'onnozweers-patch-1'
2020-06-28 16:03:56 -07:00
Vidar Holen
40aacc3345
Merge branch 'patch-1' of https://github.com/onnozweers/shellcheck into onnozweers-patch-1
2020-06-28 16:03:44 -07:00
Vidar Holen
739eaadbf5
Warn about extra spaces between ((s in for((;;))
2020-06-28 16:01:15 -07:00
Stavros Ntentos
6b88a341f3
Autolink https://www.shellcheck.net/
2020-06-28 01:47:02 +03:00
Aurelio Jargas
a61d8a232c
SC1102: Fix typo in error message: substition
2020-06-26 02:13:33 +02:00
Vidar Holen
12d9c1b76d
Clarify that SC1090 refers to ShellCheck, not sh
2020-06-24 11:50:27 -07:00
Onno Zweers
a2b5b6a500
Rephrase: *Shellcheck* can't follow non-constant source
...
The message "Can't follow non-constant source. Use a directive to specify location." set me off on the wrong foot. At first, I thought it meant "In bash, you can't source a script specified by a variable." It was only after reading the wiki page for this message https://github.com/koalaman/shellcheck/wiki/SC1090 that I understood that the problem is that *shellcheck* can't check the sourced file. So I would suggest to rephrase this message so that it is more clear that the problem is in the checking, not in the running of the script.
2020-06-03 11:37:53 +02:00
Vidar Holen
5cf2c00ff7
Warn about defining and using an alias in a single command ( fixes #1807 )
2020-05-25 23:24:33 -07:00
Vidar Holen
a08ad3bee9
Count $# as an argument reference in SC2120
2020-05-25 23:24:33 -07:00
Vidar Holen
417e13f129
Merge pull request #1950 from geeseven/aur-shellcheck-bin
...
update dependency free AUR package
2020-05-25 18:06:35 -07:00
geeseven
536cb584f4
update dependency free AUR package
...
The `shellcheck-static` AUR package has been removed and `shellcheck-bin` is an option for a dependency free AUR package.
2020-05-12 14:58:15 -05:00
Vidar Holen
c2a15ce8e9
Allow disabling SC1072/SC1073 with annotations ( fixes #1931 )
2020-05-03 21:57:16 -07:00
Vidar Holen
d6adbfde78
Improve SC2259/60/61 messages
2020-05-03 21:46:16 -07:00
Vidar Holen
2030b83607
Warn about duplicate uses of stdin/out/err
2020-05-03 11:54:25 -07:00
Vidar Holen
8aa40c43ed
Merge pull request #1926 from scop/spelling
...
Spelling fixes
2020-05-02 18:39:44 -07:00
Vidar Holen
5a42f4b938
Merge pull request #1927 from scop/sc-prefix
...
Use SC prefix for disable= in man page
2020-04-25 16:37:55 -07:00
Vidar Holen
a7a406c43c
Merge pull request #1925 from josephcsible/nofromright
...
Revert "Use fromRight instead of reimplementing it"
2020-04-25 16:37:22 -07:00
Ville Skyttä
1d126960f3
Use SC prefix for disable= in man page
2020-04-25 08:33:10 +03:00
Ville Skyttä
60e80e4ce1
Spelling fixes
2020-04-25 08:29:38 +03:00
Joseph C. Sible
e0daa936d2
Revert "Use fromRight instead of reimplementing it"
...
We still support GHC 8.0, which didn't have fromRight.
This reverts commit 64c31d9142
.
2020-04-24 22:14:08 -04:00
Vidar Holen
75863a887e
Merge pull request #1918 from josephcsible/getsuspiciousregexwildcard
...
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 15:32:00 -07:00
Vidar Holen
413f0048b8
Merge pull request #1917 from josephcsible/thenskip
...
Simplify thenSkip, and use in another location
2020-04-12 15:26:36 -07:00
Vidar Holen
e7b5fb9742
Merge pull request #1907 from josephcsible/formatters
...
Clean up formatters
2020-04-12 15:23:17 -07:00
Vidar Holen
30523555af
Merge pull request #1906 from josephcsible/shellsupport
...
Simplify ShellSupport
2020-04-12 15:22:52 -07:00
Vidar Holen
58d3e50f43
Merge pull request #1905 from josephcsible/skiprepeating
...
Make skipRepeating lazier and faster
2020-04-12 15:21:39 -07:00
Vidar Holen
73cc11fd0a
Merge pull request #1901 from josephcsible/bracedstring
...
Mostly get rid of bracedString
2020-04-12 15:14:50 -07:00
Joseph C. Sible
163c710ba7
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 16:15:45 -04:00
Vidar Holen
ab1610b004
Merge pull request #1903 from josephcsible/fixer
...
Only perform the comparisons once
2020-04-11 17:23:51 -07:00
Vidar Holen
148468be70
Merge pull request #1904 from josephcsible/commands
...
Simplify Commands
2020-04-11 17:23:39 -07:00
Vidar Holen
5eac721fcf
Merge pull request #1902 from josephcsible/astlib
...
Clean up ASTLib
2020-04-11 17:23:08 -07:00
Joseph C. Sible
b58bb4ba9d
Move bracedString to be local to its last use site
2020-04-11 19:24:11 -04:00
Joseph C. Sible
999b7e2596
Get rid of bracedString everywhere it's easy to
2020-04-11 19:24:11 -04:00
Joseph C. Sible
a9d564a8bc
Combine bracedString into getSingleUnmodifiedVariable
...
Everywhere we used getSingleUnmodifiedVariable, we just called bracedString on
the result. Move this into that function instead, and rename it accordingly.
2020-04-11 19:23:13 -04:00
Joseph C. Sible
8a7497c4f0
Simplify checkVariableBraces
2020-04-11 19:23:13 -04:00
Vidar Holen
1eac0d7340
Merge pull request #1900 from josephcsible/analyzerlib
...
Clean up AnalyzerLib
2020-04-11 16:21:20 -07:00
Vidar Holen
f8c1ffb0dc
Merge pull request #1898 from josephcsible/nameexpansion
...
Simplify nameExpansion
2020-04-11 16:18:54 -07:00
Joseph C. Sible
3e17a20965
Simplify thenSkip, and use in another location
2020-04-11 17:29:28 -04:00
Joseph C. Sible
1c6202dba4
Avoid some awkward parentheses with forM_
2020-04-05 22:25:19 -04:00
Joseph C. Sible
64c31d9142
Use fromRight instead of reimplementing it
2020-04-05 22:23:22 -04:00
Joseph C. Sible
8a6679fd8a
Remove unnecessary fromMaybe and when from bashism
2020-04-05 22:03:50 -04:00
Joseph C. Sible
facf0d1e27
Write getLiteralArgs with foldr and without fromMaybe or monads
2020-04-05 21:59:27 -04:00
Joseph C. Sible
cd38afce26
Make it slightly lazier still (and more clear)
2020-04-05 21:46:08 -04:00
Joseph C. Sible
5084ba8d7e
Make skipRepeating lazier and faster
2020-04-05 21:39:14 -04:00
Joseph C. Sible
ed331b816b
Simplify warnRedundant
2020-04-05 20:32:39 -04:00
Joseph C. Sible
cfa2a663af
Simplify checkSetAssignment
2020-04-05 20:30:37 -04:00
Joseph C. Sible
df4928f4e3
Use MultiWayIf instead of case-matching on ()
2020-04-05 20:30:37 -04:00