9584266a8b
Escape control characters when adding user data to messages
2020-12-31 12:28:48 -08:00
5fbaae2bb3
Don't treat ${!x@} as reference of x ( fixes #2116 )
2020-12-30 20:55:18 -08:00
fbb14d6b38
Improve checks for = in command names ( fixes #2102 )
2020-12-30 20:30:43 -08:00
2cfd1f2714
Fuse maps
2020-12-28 18:13:34 -05:00
953d9bc56d
Remove unused helper stub
2020-12-28 18:13:34 -05:00
e272fa04ee
Remove redundant bind and return
2020-12-28 18:13:34 -05:00
81e84c2939
Use execState instead of snd . runState
2020-12-28 18:13:34 -05:00
34939ca0b7
Fuse map into any
2020-12-28 18:13:34 -05:00
e7820479f0
Use find
2020-12-28 18:13:34 -05:00
8480563672
Use syntactic sugar instead of building lists by hand
2020-12-28 18:13:34 -05:00
dfbcc9595e
Use mapM instead of reimplementing it
2020-12-28 17:48:58 -05:00
2c0766825e
Implement groupByLink in terms of foldr
2020-12-28 17:45:11 -05:00
cb4f4e7edc
Use mapM_ instead of reimplementing it
2020-12-28 17:34:52 -05:00
0607039d41
Simplify actualArgs
2020-12-28 17:21:47 -05:00
46f177b5be
Simplify parseArgs
2020-12-28 17:19:08 -05:00
eaccd3d02c
Simplify parser
2020-12-28 17:19:08 -05:00
35033a9f2f
Remove unnecessary use of Maybe from shellFor
2020-12-28 17:09:50 -05:00
19355226e1
Change error 2076 to a warning.
...
Implementing the suggestion by @pixarbuff #1985 .
2020-12-27 00:27:36 +01:00
4e7e3f9456
Add Haddock markup to SystemInterface
2020-12-22 09:15:57 +00:00
bd3299edd3
Treat 'exec $1' like '$1' for the purpose of quoting ( fixes #2068 )
2020-12-17 20:31:45 -08:00
cc3884cf9f
Support env -S/--split-string in shebangs ( fixes #2105 )
2020-12-12 20:24:32 -08:00
6ba1af0898
Warn when a variable is assigned to itself
2020-12-11 20:28:36 -08:00
8e332ce879
Improve handling of trailing tokens for []/compounds ( fixes #2091 )
2020-12-06 21:26:24 -08:00
b625562d60
Add POSIX checks for more Bash-specific variables ( fixes #2093 )
2020-12-05 20:11:12 -08:00
65044c2568
SC2095: Also warn if the command is backgrounded
2020-11-29 13:01:23 -08:00
619662adb6
Add readonly to SC2155
...
This adds a warning for readonly masking the return value of function.
This is mentioned in the wiki
https://github.com/koalaman/shellcheck/wiki/SC2155#problematic-code-in-the-case-of-readonly
but didn't actually produce a warning.
Fixes https://github.com/koalaman/shellcheck/issues/1336
2020-10-23 17:29:04 -07:00
28d3279ba6
Optional style warning about [ x$var = xval ]
2020-10-19 20:04:58 -07:00
256457c47a
Use getopts parser to find 'read' arrays ( fixes #2073 )
2020-10-18 22:57:16 -07:00
3104cec770
SC2267: Warn about xargs -i ( fixes #2058 )
2020-10-18 22:10:14 -07:00
f100c2939e
Rewrite getopts style option parser
2020-10-18 21:34:58 -07:00
8d99926554
Recognize `local -x` similarly to `export` ( fixes #2069 )
2020-10-18 15:15:31 -07:00
218deb6d01
Update SC2091/SC2092 message and ignore in quotes.
2020-09-08 19:30:13 -07:00
c4cc2debb7
Improve compatibility checks
2020-09-07 21:05:49 -07:00
cfd68ee0c2
Give each sh/dash compatibility warning its own SC3xxx error code
2020-09-01 16:48:14 -07:00
58783ab3cc
Allow specifying ranges in disable directives
2020-09-01 16:22:15 -07:00
43191fa71d
Suppress SC2035 for echo * and printf * ( fixes #2036 )
2020-09-01 14:19:28 -07:00
c9be7ab2eb
Parse assignments according to spec ( fixes #2022 )
2020-08-23 18:46:13 -07:00
9e59bcca91
Upgrade SC2169 (unsupported in dash) from warning to error ( fixes #2013 )
2020-08-23 15:49:20 -07:00
a62d9f10c2
Warn when using &/| between test statements
2020-08-23 15:43:33 -07:00
50067ddf94
Consider variables in -z/-n tests to be checked
2020-08-08 12:32:20 -07:00
3fa5b7d3bd
Merge branch 'supportMinusNZ' of https://github.com/donnerpeter/shellcheck into donnerpeter-supportMinusNZ
2020-08-08 11:22:00 -07:00
e779aedac3
Modernize getting mapfile array name
2020-08-07 16:41:18 -07:00
3ef1175566
Merge branch 'issue_1759_mapfile_proc_substition' of https://github.com/Gandalf-/shellcheck into Gandalf--issue_1759_mapfile_proc_substition
2020-08-07 15:57:59 -07:00
3e50a2fce8
Suppress SC2216 for du --files0-from or --exclude-from ( fixes #1286 )
2020-08-07 14:59:34 -07:00
1ac2c31728
Warn when shell functions blatantly recurse ( fixes #1994 )
2020-07-27 21:50:33 -07:00
cc81bdee31
Improve SC1033/SC1034 message
2020-07-27 18:44:07 -07:00
34885142e7
Handle tilde expansion in pattern matching ( fixes #1769 )
2020-07-27 18:34:42 -07:00
14e6806092
Handle literal linefeeds in printf format strings ( fixes #2007 )
2020-07-25 17:36:22 -07:00
5d753212fb
Improve handling of command prefixes like exec/command ( fixes #2008 )
2020-07-25 13:45:05 -07:00
5b86777f9d
Warn about non-POSIX case modification expansions ( fixes #1977 )
2020-07-22 17:32:00 -07:00
210cdcd01a
Treat $x/ or $(x)/ as ./ when finding sourced files ( fixes #1998 )
2020-06-28 17:24:07 -07:00
b52f58473d
Merge pull request #1999 from aureliojargas/patch-1
...
SC1102: Fix typo in error message: substition
2020-06-28 16:04:56 -07:00
739eaadbf5
Warn about extra spaces between ((s in for((;;))
2020-06-28 16:01:15 -07:00
a61d8a232c
SC1102: Fix typo in error message: substition
2020-06-26 02:13:33 +02:00
12d9c1b76d
Clarify that SC1090 refers to ShellCheck, not sh
2020-06-24 11:50:27 -07:00
5cf2c00ff7
Warn about defining and using an alias in a single command ( fixes #1807 )
2020-05-25 23:24:33 -07:00
a08ad3bee9
Count $# as an argument reference in SC2120
2020-05-25 23:24:33 -07:00
c2a15ce8e9
Allow disabling SC1072/SC1073 with annotations ( fixes #1931 )
2020-05-03 21:57:16 -07:00
d6adbfde78
Improve SC2259/60/61 messages
2020-05-03 21:46:16 -07:00
2030b83607
Warn about duplicate uses of stdin/out/err
2020-05-03 11:54:25 -07:00
8aa40c43ed
Merge pull request #1926 from scop/spelling
...
Spelling fixes
2020-05-02 18:39:44 -07:00
60e80e4ce1
Spelling fixes
2020-04-25 08:29:38 +03:00
e0daa936d2
Revert "Use fromRight instead of reimplementing it"
...
We still support GHC 8.0, which didn't have fromRight.
This reverts commit 64c31d9142
2020-04-24 22:14:08 -04:00
75863a887e
Merge pull request #1918 from josephcsible/getsuspiciousregexwildcard
...
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 15:32:00 -07:00
413f0048b8
Merge pull request #1917 from josephcsible/thenskip
...
Simplify thenSkip, and use in another location
2020-04-12 15:26:36 -07:00
e7b5fb9742
Merge pull request #1907 from josephcsible/formatters
...
Clean up formatters
2020-04-12 15:23:17 -07:00
30523555af
Merge pull request #1906 from josephcsible/shellsupport
...
Simplify ShellSupport
2020-04-12 15:22:52 -07:00
58d3e50f43
Merge pull request #1905 from josephcsible/skiprepeating
...
Make skipRepeating lazier and faster
2020-04-12 15:21:39 -07:00
73cc11fd0a
Merge pull request #1901 from josephcsible/bracedstring
...
Mostly get rid of bracedString
2020-04-12 15:14:50 -07:00
163c710ba7
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 16:15:45 -04:00
ab1610b004
Merge pull request #1903 from josephcsible/fixer
...
Only perform the comparisons once
2020-04-11 17:23:51 -07:00
148468be70
Merge pull request #1904 from josephcsible/commands
...
Simplify Commands
2020-04-11 17:23:39 -07:00
5eac721fcf
Merge pull request #1902 from josephcsible/astlib
...
Clean up ASTLib
2020-04-11 17:23:08 -07:00
b58bb4ba9d
Move bracedString to be local to its last use site
2020-04-11 19:24:11 -04:00
999b7e2596
Get rid of bracedString everywhere it's easy to
2020-04-11 19:24:11 -04:00
a9d564a8bc
Combine bracedString into getSingleUnmodifiedVariable
...
Everywhere we used getSingleUnmodifiedVariable, we just called bracedString on
the result. Move this into that function instead, and rename it accordingly.
2020-04-11 19:23:13 -04:00
8a7497c4f0
Simplify checkVariableBraces
2020-04-11 19:23:13 -04:00
1eac0d7340
Merge pull request #1900 from josephcsible/analyzerlib
...
Clean up AnalyzerLib
2020-04-11 16:21:20 -07:00
f8c1ffb0dc
Merge pull request #1898 from josephcsible/nameexpansion
...
Simplify nameExpansion
2020-04-11 16:18:54 -07:00
3e17a20965
Simplify thenSkip, and use in another location
2020-04-11 17:29:28 -04:00
1c6202dba4
Avoid some awkward parentheses with forM_
2020-04-05 22:25:19 -04:00
64c31d9142
Use fromRight instead of reimplementing it
2020-04-05 22:23:22 -04:00
8a6679fd8a
Remove unnecessary fromMaybe and when from bashism
2020-04-05 22:03:50 -04:00
facf0d1e27
Write getLiteralArgs with foldr and without fromMaybe or monads
2020-04-05 21:59:27 -04:00
cd38afce26
Make it slightly lazier still (and more clear)
2020-04-05 21:46:08 -04:00
5084ba8d7e
Make skipRepeating lazier and faster
2020-04-05 21:39:14 -04:00
ed331b816b
Simplify warnRedundant
2020-04-05 20:32:39 -04:00
cfa2a663af
Simplify checkSetAssignment
2020-04-05 20:30:37 -04:00
df4928f4e3
Use MultiWayIf instead of case-matching on ()
2020-04-05 20:30:37 -04:00
9747b1d5c3
Simplify checkArg
2020-04-05 20:10:56 -04:00
fa841cb270
Prefer pattern matching in undirected
2020-04-05 20:08:02 -04:00
e8501151dd
Use a guard instead of unless
2020-04-05 20:04:54 -04:00
9027a9239f
Use pattern matching instead of snd
2020-04-05 20:03:17 -04:00
773e98868d
Use foldr in checkFindNameGlob
2020-04-05 19:53:40 -04:00
d45ab327b0
Only perform the comparisons once
2020-04-05 19:45:28 -04:00
0f9b0f18a4
Remove unnecessary cases from wordToPseudoGlob
2020-04-05 19:30:21 -04:00
322842b57e
Remove unnecessary monadicity from wordToPseudoGlob
2020-04-05 19:29:40 -04:00
b6cff5ea0e
Simplify getAssociativeArrays
2020-04-05 19:06:30 -04:00
8f105074fe
Simplify getCommandNameAndToken
2020-04-05 19:01:56 -04:00
d22e0aa4a7
Simplify process
...
Note to self: This is a lot like foldr or traverse, and would be trivial to
implement as such if it didn't need to peek ahead when takesArg is true. I
wonder if there's a clean way to implement it in terms of one of them anyway.
2020-04-05 16:45:45 -04:00
Vidar Holen
Joseph C. Sible
Martin Bagge / brother
Pepe Iborra
Keith Smiley
Aurelio Jargas
Ville Skyttä