619662adb6
Add readonly to SC2155
...
This adds a warning for readonly masking the return value of function.
This is mentioned in the wiki
https://github.com/koalaman/shellcheck/wiki/SC2155#problematic-code-in-the-case-of-readonly
but didn't actually produce a warning.
Fixes https://github.com/koalaman/shellcheck/issues/1336
2020-10-23 17:29:04 -07:00
28d3279ba6
Optional style warning about [ x$var = xval ]
2020-10-19 20:04:58 -07:00
256457c47a
Use getopts parser to find 'read' arrays ( fixes #2073 )
2020-10-18 22:57:16 -07:00
3104cec770
SC2267: Warn about xargs -i ( fixes #2058 )
2020-10-18 22:10:14 -07:00
f100c2939e
Rewrite getopts style option parser
2020-10-18 21:34:58 -07:00
8d99926554
Recognize `local -x` similarly to `export` ( fixes #2069 )
2020-10-18 15:15:31 -07:00
218deb6d01
Update SC2091/SC2092 message and ignore in quotes.
2020-09-08 19:30:13 -07:00
c4cc2debb7
Improve compatibility checks
2020-09-07 21:05:49 -07:00
cfd68ee0c2
Give each sh/dash compatibility warning its own SC3xxx error code
2020-09-01 16:48:14 -07:00
58783ab3cc
Allow specifying ranges in disable directives
2020-09-01 16:22:15 -07:00
43191fa71d
Suppress SC2035 for echo * and printf * ( fixes #2036 )
2020-09-01 14:19:28 -07:00
c9be7ab2eb
Parse assignments according to spec ( fixes #2022 )
2020-08-23 18:46:13 -07:00
9e59bcca91
Upgrade SC2169 (unsupported in dash) from warning to error ( fixes #2013 )
2020-08-23 15:49:20 -07:00
a62d9f10c2
Warn when using &/| between test statements
2020-08-23 15:43:33 -07:00
50067ddf94
Consider variables in -z/-n tests to be checked
2020-08-08 12:32:20 -07:00
3fa5b7d3bd
Merge branch 'supportMinusNZ' of https://github.com/donnerpeter/shellcheck into donnerpeter-supportMinusNZ
2020-08-08 11:22:00 -07:00
e779aedac3
Modernize getting mapfile array name
2020-08-07 16:41:18 -07:00
3ef1175566
Merge branch 'issue_1759_mapfile_proc_substition' of https://github.com/Gandalf-/shellcheck into Gandalf--issue_1759_mapfile_proc_substition
2020-08-07 15:57:59 -07:00
3e50a2fce8
Suppress SC2216 for du --files0-from or --exclude-from ( fixes #1286 )
2020-08-07 14:59:34 -07:00
1ac2c31728
Warn when shell functions blatantly recurse ( fixes #1994 )
2020-07-27 21:50:33 -07:00
cc81bdee31
Improve SC1033/SC1034 message
2020-07-27 18:44:07 -07:00
34885142e7
Handle tilde expansion in pattern matching ( fixes #1769 )
2020-07-27 18:34:42 -07:00
14e6806092
Handle literal linefeeds in printf format strings ( fixes #2007 )
2020-07-25 17:36:22 -07:00
5d753212fb
Improve handling of command prefixes like exec/command ( fixes #2008 )
2020-07-25 13:45:05 -07:00
5b86777f9d
Warn about non-POSIX case modification expansions ( fixes #1977 )
2020-07-22 17:32:00 -07:00
210cdcd01a
Treat $x/ or $(x)/ as ./ when finding sourced files ( fixes #1998 )
2020-06-28 17:24:07 -07:00
b52f58473d
Merge pull request #1999 from aureliojargas/patch-1
...
SC1102: Fix typo in error message: substition
2020-06-28 16:04:56 -07:00
739eaadbf5
Warn about extra spaces between ((s in for((;;))
2020-06-28 16:01:15 -07:00
a61d8a232c
SC1102: Fix typo in error message: substition
2020-06-26 02:13:33 +02:00
12d9c1b76d
Clarify that SC1090 refers to ShellCheck, not sh
2020-06-24 11:50:27 -07:00
5cf2c00ff7
Warn about defining and using an alias in a single command ( fixes #1807 )
2020-05-25 23:24:33 -07:00
a08ad3bee9
Count $# as an argument reference in SC2120
2020-05-25 23:24:33 -07:00
c2a15ce8e9
Allow disabling SC1072/SC1073 with annotations ( fixes #1931 )
2020-05-03 21:57:16 -07:00
d6adbfde78
Improve SC2259/60/61 messages
2020-05-03 21:46:16 -07:00
2030b83607
Warn about duplicate uses of stdin/out/err
2020-05-03 11:54:25 -07:00
8aa40c43ed
Merge pull request #1926 from scop/spelling
...
Spelling fixes
2020-05-02 18:39:44 -07:00
60e80e4ce1
Spelling fixes
2020-04-25 08:29:38 +03:00
e0daa936d2
Revert "Use fromRight instead of reimplementing it"
...
We still support GHC 8.0, which didn't have fromRight.
This reverts commit 64c31d9142
2020-04-24 22:14:08 -04:00
75863a887e
Merge pull request #1918 from josephcsible/getsuspiciousregexwildcard
...
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 15:32:00 -07:00
413f0048b8
Merge pull request #1917 from josephcsible/thenskip
...
Simplify thenSkip, and use in another location
2020-04-12 15:26:36 -07:00
e7b5fb9742
Merge pull request #1907 from josephcsible/formatters
...
Clean up formatters
2020-04-12 15:23:17 -07:00
30523555af
Merge pull request #1906 from josephcsible/shellsupport
...
Simplify ShellSupport
2020-04-12 15:22:52 -07:00
58d3e50f43
Merge pull request #1905 from josephcsible/skiprepeating
...
Make skipRepeating lazier and faster
2020-04-12 15:21:39 -07:00
73cc11fd0a
Merge pull request #1901 from josephcsible/bracedstring
...
Mostly get rid of bracedString
2020-04-12 15:14:50 -07:00
163c710ba7
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 16:15:45 -04:00
ab1610b004
Merge pull request #1903 from josephcsible/fixer
...
Only perform the comparisons once
2020-04-11 17:23:51 -07:00
148468be70
Merge pull request #1904 from josephcsible/commands
...
Simplify Commands
2020-04-11 17:23:39 -07:00
5eac721fcf
Merge pull request #1902 from josephcsible/astlib
...
Clean up ASTLib
2020-04-11 17:23:08 -07:00
b58bb4ba9d
Move bracedString to be local to its last use site
2020-04-11 19:24:11 -04:00
999b7e2596
Get rid of bracedString everywhere it's easy to
2020-04-11 19:24:11 -04:00
a9d564a8bc
Combine bracedString into getSingleUnmodifiedVariable
...
Everywhere we used getSingleUnmodifiedVariable, we just called bracedString on
the result. Move this into that function instead, and rename it accordingly.
2020-04-11 19:23:13 -04:00
8a7497c4f0
Simplify checkVariableBraces
2020-04-11 19:23:13 -04:00
1eac0d7340
Merge pull request #1900 from josephcsible/analyzerlib
...
Clean up AnalyzerLib
2020-04-11 16:21:20 -07:00
f8c1ffb0dc
Merge pull request #1898 from josephcsible/nameexpansion
...
Simplify nameExpansion
2020-04-11 16:18:54 -07:00
3e17a20965
Simplify thenSkip, and use in another location
2020-04-11 17:29:28 -04:00
1c6202dba4
Avoid some awkward parentheses with forM_
2020-04-05 22:25:19 -04:00
64c31d9142
Use fromRight instead of reimplementing it
2020-04-05 22:23:22 -04:00
8a6679fd8a
Remove unnecessary fromMaybe and when from bashism
2020-04-05 22:03:50 -04:00
facf0d1e27
Write getLiteralArgs with foldr and without fromMaybe or monads
2020-04-05 21:59:27 -04:00
cd38afce26
Make it slightly lazier still (and more clear)
2020-04-05 21:46:08 -04:00
5084ba8d7e
Make skipRepeating lazier and faster
2020-04-05 21:39:14 -04:00
ed331b816b
Simplify warnRedundant
2020-04-05 20:32:39 -04:00
cfa2a663af
Simplify checkSetAssignment
2020-04-05 20:30:37 -04:00
df4928f4e3
Use MultiWayIf instead of case-matching on ()
2020-04-05 20:30:37 -04:00
9747b1d5c3
Simplify checkArg
2020-04-05 20:10:56 -04:00
fa841cb270
Prefer pattern matching in undirected
2020-04-05 20:08:02 -04:00
e8501151dd
Use a guard instead of unless
2020-04-05 20:04:54 -04:00
9027a9239f
Use pattern matching instead of snd
2020-04-05 20:03:17 -04:00
773e98868d
Use foldr in checkFindNameGlob
2020-04-05 19:53:40 -04:00
d45ab327b0
Only perform the comparisons once
2020-04-05 19:45:28 -04:00
0f9b0f18a4
Remove unnecessary cases from wordToPseudoGlob
2020-04-05 19:30:21 -04:00
322842b57e
Remove unnecessary monadicity from wordToPseudoGlob
2020-04-05 19:29:40 -04:00
b6cff5ea0e
Simplify getAssociativeArrays
2020-04-05 19:06:30 -04:00
8f105074fe
Simplify getCommandNameAndToken
2020-04-05 19:01:56 -04:00
d22e0aa4a7
Simplify process
...
Note to self: This is a lot like foldr or traverse, and would be trivial to
implement as such if it didn't need to peek ahead when takesArg is true. I
wonder if there's a clean way to implement it in terms of one of them anyway.
2020-04-05 16:45:45 -04:00
fb55072302
Implement supportsArrays with pattern-matching
2020-04-05 16:30:59 -04:00
0cc5ed4563
Don't bother with asks if you're just immediately binding the result anyway
2020-04-05 16:25:43 -04:00
ca41440a67
Simplify getSpecial
2020-04-05 16:21:07 -04:00
1cf0aa25e9
Simplify dropPrefix
2020-04-05 16:19:18 -04:00
4604066c37
Use head instead of (!! 0)
2020-04-05 16:16:12 -04:00
2ebf522a52
Simplify isArrayFlag
2020-04-05 16:13:55 -04:00
e4eb2d157f
Remove an unnecessary operator section
2020-04-05 16:13:55 -04:00
f109f9ab92
Remove unnecessary as-patterns
2020-04-05 16:13:55 -04:00
67e091674e
Remove unnecessary maybeToList
...
The functions we use here are polymorphic enough to work in the [] monad,
so there's no point to use them in the Maybe monad and then convert.
2020-04-05 16:13:54 -04:00
f833ee3d5a
Use a list comprehension instead of a concatMap with extra lists
2020-04-05 15:54:12 -04:00
f55d8c45e5
Simplify causesSubshell
2020-04-05 15:54:12 -04:00
14ee462ccd
Use execState instead of reimplementing it
2020-04-05 15:50:42 -04:00
b3c04ce3d0
Implement findFirst in terms of foldr
2020-04-05 15:50:42 -04:00
b0dbc79f69
Remove unnecessary Maybe from isQuoteFreeElement
2020-04-05 15:07:36 -04:00
2a8170ba05
Use force instead of reimplementing it
2020-04-05 15:01:57 -04:00
01f4423465
Disable SC2257 about > $((i=42)) for Dash
2020-04-05 11:38:22 -07:00
d2fa88dd91
Simplify nameExpansion
2020-04-05 14:04:23 -04:00
bd717c9d1b
Don't warn about [ 0 -ne $FOO ] || [ 0 -ne $BAR ] ( fixes #1891 )
2020-04-01 22:09:00 -07:00
da0931740f
Merge pull request #1876 from fork-graveyard/master
...
recognize `: ${parameter=word}` as assignment
2020-04-01 18:52:53 -07:00
c60323fb25
Merge pull request #1873 from josephcsible/checkwhilereadpitfalls
...
Simplify checkWhileReadPitfalls
2020-03-31 19:10:53 -07:00
db11e2f663
Merge pull request #1872 from josephcsible/checkforinquoted
...
Simplify checkForInQuoted
2020-03-31 19:10:25 -07:00
8cf037fe5e
Fix #1892 : Use pattern synonyms to clean up AST
2020-03-28 18:38:07 -04:00
7963eeab9d
Include shebang in AST traversal ( fixes #1858 )
2020-03-16 21:36:41 -07:00
7a5e261d03
recognize `: ${parameter=word}` as assignment
2020-03-16 23:04:54 +01:00
9d5363377e
Simplify checkWhileReadPitfalls
...
* Clean up usage of not
* Use a case match instead of sequence_ and a do block
2020-03-16 00:14:22 -04:00
86d470c74f
Simplify checkForInQuoted
...
* Avoid some unnecessary fmaps
* Reuse an identical pattern-match for two guards
* Apply De Morgan's law
* Use forM_ to avoid an unnecessary where
2020-03-15 16:05:55 -04:00
a57f6d2886
Improve detection of for loops with single values
2020-03-15 11:30:56 -07:00
d28c8f883f
Merge pull request #1865 from josephcsible/patch-1
...
Use headOrDefault instead of fromMaybe and listToMaybe
2020-03-14 21:21:13 -07:00
c43b19f897
Make SC2095 (ssh in while read loops) more robust and suggest fixes
2020-03-14 21:15:47 -07:00
45a67e7c64
Use headOrDefault instead of fromMaybe and listToMaybe
2020-03-10 13:27:52 -04:00
741d499b3d
src/ShellCheck/Analytics.hs: suggest using a shell directive for SC2148
2020-03-07 19:23:35 -06:00
7b998239af
SC2257: Warn when changing arithmetic variables in redirections
2020-02-17 18:16:57 -08:00
4c9210af79
Inspect 'alias' commands for referenced variables ( Fixes #1832 )
2020-02-17 14:20:21 -08:00
a75219e525
Remove unused instance Ord Replacement ( fixes #1829 )
2020-02-17 12:44:38 -08:00
99d6df8a08
Bump SC1102/SC1105 about ambiguous `$((` to Error ( fixes #1836 )
2020-02-17 12:27:24 -08:00
106f321cf0
Parse keywords with case sensitivity ( fixes #1809 )
2020-02-17 11:13:29 -08:00
eecd003e2d
Optimize patterns in checkFindNameGlob
...
1. Instead of pattern-matching the same list multiple times, do it only
once and then pass the pieces separately.
2. Don't reconstruct an object equivalent to one we just deconstructed.
2020-02-11 01:04:49 -05:00
440d0038aa
Remove a partial pattern match equivalent to fromJust from checkFindNameGlob
2020-02-11 01:03:10 -05:00
c2d67c15f8
Merge pull request #1802 from szydell/master
...
SC2016, repair false error for M language parser
2020-02-10 18:25:28 -08:00
6043deb8f2
Merge pull request #1824 from josephcsible/patch-1
...
Simplify literalEquals
2020-02-10 18:20:05 -08:00
d0beac6d0b
Merge pull request #1826 from josephcsible/nofromjust
...
Use the Identity monad to avoid unnecessary uses of fromJust
2020-02-10 18:05:36 -08:00
b88b253cad
Merge pull request #1827 from josephcsible/nofromjust2
...
Remove more unnecessary uses of fromJust
2020-02-10 18:01:38 -08:00
85c49a8af9
Simplify mockedSystemInterface
2020-02-09 23:50:48 -05:00
42abcb7ae2
Simplify shellFromFilename
2020-02-09 23:18:09 -05:00
d5c5128115
Use isJust instead of reimplementing it
2020-02-09 23:18:09 -05:00
6d06103cab
Remove unnecessary uses of head
2020-02-09 23:18:09 -05:00
c95914f9b3
Simplify determineShell
2020-02-09 23:18:09 -05:00
ea24e25efd
Use Map.member instead of isJust and Map.lookup
2020-02-09 23:18:09 -05:00
8f0448133c
Use isNothing instead of reimplementing it
2020-02-09 23:18:08 -05:00
7fc9496320
Use forM_ instead of reimplementing it
2020-02-09 23:18:08 -05:00
962fad038c
Avoid a zip that breaks fusion
2020-02-09 23:18:08 -05:00
a223a7a5a5
Remove unnecessary fromMaybes
2020-02-09 23:18:08 -05:00
8e9290badb
Do toLower earlier
2020-02-09 23:17:53 -05:00
292b0840d9
Simplify a double negative
2020-02-09 23:17:53 -05:00
43c24cf79c
Use Map.! instead of reimplementing it
2020-02-09 23:17:53 -05:00
21ad4196db
Simplify findFunction
2020-02-09 23:17:53 -05:00
172aa7c4fc
Avoid unnecessary use of when and unless
2020-02-09 23:17:53 -05:00
c290eace54
Inline an uncurry
2020-02-09 23:17:53 -05:00
a6efd02807
Simplify <> for SpaceStatus
2020-02-09 23:17:53 -05:00
057cc714b3
Simplify matchToken
2020-02-09 23:17:52 -05:00
0e00249eae
Use void instead of do and return ()
2020-02-09 23:17:52 -05:00
0ca50159ec
Use head instead of reimplementing it
...
Normally I wouldn't use head, but this code is partial anyway.
2020-02-09 23:17:52 -05:00
7e6a556ef1
Get rid of potentially
...
This already exists as sequence_.
2020-02-09 23:17:52 -05:00
4bfe6496d9
Simplify check and checkTranslatedStringVariable
...
Avoid the "potentially" and "Maybe" business, and just use regular guards.
2020-02-09 23:17:52 -05:00
ffbbfcfe25
Use mapM_ and sequence_ instead of reimplementing them
2020-02-09 23:17:52 -05:00
cc424bac11
Use find instead of take 1 and filter
2020-02-09 23:17:52 -05:00
cb01cbf7eb
Use mapM instead of implementing a slower version of it
2020-02-09 23:17:52 -05:00
1e32139f66
Replace mapMaybe and concatMap with list comprehensions
2020-02-09 23:17:52 -05:00
4d92a2e15c
Add getLiteralStringDef and simplify with it
2020-02-09 21:36:38 -05:00
f8648e5465
Switch getLiteralStringExt to Identity where it can never be Nothing
2020-02-09 21:26:42 -05:00
4fd8de058b
Remove more unnecessary uses of fromJust
2020-02-08 23:48:36 -05:00
aaffe38198
Use the Identity monad to avoid unnecessary uses of fromJust
2020-02-08 23:20:54 -05:00
ef51ed3950
Simplify literalEquals
2020-02-08 14:09:17 -05:00
9d604ae732
Merge pull request #1822 from yetamrra/arrayindex
...
SC2191: Tighten index checks
2020-02-08 10:48:07 -08:00
1ca0b72329
Merge pull request #1816 from josephcsible/cleanups
...
Various cleanups and refactorings
2020-02-08 10:38:27 -08:00
Keith Smiley
Vidar Holen
Aurelio Jargas
Ville Skyttä
Joseph C. Sible
girst
Austin English