3c5c74ff04
Add quote warning specific to : ${var=val}. Fixes #1084
2018-01-06 10:53:53 -08:00
6ed60b403f
Extend SC2216/SC2217 with 'true' and 'false'
2017-12-21 03:29:17 +00:00
161801a86e
convert http:// URIs to https://
...
Also update the ShellCheck homepage to the new dedicated domain.
2017-12-14 01:06:43 -05:00
51e6bf809f
Merge pull request #1041 from LukeShu/fix-isClosingFileOp
...
Fix isClosingFileOp (fixes issue #862 )
2017-11-08 10:15:21 -08:00
53f63b85bb
Use Data.Map.Strict instead of Map.insertWith'
2017-11-05 20:11:04 -08:00
df068bc8ed
Fix isClosingFileOp (fixes issue #862 )
...
The isClosingFileOp function expected closing file ops to use T_IoFile, but
they actually use T_IoDuplicate; so it effectively always returned False.
2017-11-05 18:53:01 -05:00
3785a08906
Don't suggest $@ in [[ $* = "" ]] ( #976 )
2017-10-01 10:27:21 -07:00
74c199b51a
Warn when one case pattern overrides another.
2017-09-16 15:23:51 -07:00
81388cefd2
Warn when calling functions before defining them.
2017-07-10 22:53:26 -07:00
5bd33dbf92
Warn when piping/redirecting to mv/cp/echo/etc ( #921 )
2017-07-03 16:02:58 -07:00
a839a6657b
Warn when commands start with dashes ( #938 )
2017-07-03 12:06:59 -07:00
954aa99b11
Analytics.hs: Refactor cd, popd and pushd checks
...
* Refactor the check of unchecked `cd`, `pushd` and `popd` into one
function.
Signed-off-by: mr.Shu <mr@shu.io>
2017-06-12 12:16:01 +02:00
79872f92f8
Merge branch 'master' of https://github.com/koalaman/shellcheck into mrshu/pushd-popd-like-cd
...
Signed-off-by: mr.Shu <mr@shu.io>
2017-06-12 11:29:19 +02:00
ce950edbfd
Don't trigger SC2026 when followed by empty literals ( #923 )
2017-06-03 09:38:47 -07:00
6f4e06d83c
Avoid rescanning tree for lastpipe on every node.
2017-05-28 16:04:42 -07:00
505ff7832f
Recognize bash's `shopt -s lastpipe`
...
Fixes #732 .
2017-05-28 14:56:49 -07:00
ac3f0b3360
SC2114 about rm -rf /usr is no longer silenced by --
2017-05-28 14:44:58 -07:00
4243c6a0bf
Treat + like :+ to squash SC2068
2017-05-24 19:20:28 -07:00
9e35aa7ce8
SC2164: Make SC2164 apply to `pushd` and `popd`
...
* Since `pushd` and `popd` have the same failure cases, make the check
for SC2164 apply to them as well.
* This commit also refactors the code a bit as `hasSetE` is now used in
multiple places.
* Fixes #863 .
Signed-off-by: mr.Shu <mr@shu.io>
2017-05-14 14:00:10 +02:00
324aa3cc88
Improve and deduplicate string comparison warnings.
2017-04-22 21:09:42 -07:00
5c01b6c7f5
Parse empty [ ] conditionals
2017-04-16 18:11:00 -07:00
7604e5eb58
Warn when using a glob as a command name.
2017-04-15 19:53:09 -07:00
4fb1080809
Warn when redirecting to a literal integer.
2017-04-15 17:20:33 -07:00
4f9a80db15
Remove leftover debug trace
2017-04-15 13:44:01 -07:00
fd79e80e78
Fix SC2120 triggering on sourced files and ${!var*}
2017-04-15 11:26:47 -07:00
1fd9b474ba
Don't warn about quoting variables in [ -v 'bar[$foo]' ]
2017-04-15 10:57:10 -07:00
faafc99704
Don't trigger SC2037 when quoting (PAGER="cat" foo)
2017-04-15 10:33:56 -07:00
41b6e3d5eb
Don't warn about [ -v foo ] being unassigned.
2017-04-08 15:19:47 -07:00
da1691912b
Replace _otherwise with _ in cases
2017-04-08 14:00:52 -07:00
0feb95b337
Implement fixes suggested by HLint
2017-04-08 11:07:32 -07:00
3c75674b50
Warn about unquoted expansions in arrays.
2017-04-02 14:28:12 -07:00
8e5e77ad76
Don't suggest removing $ for (( $! + ${!var} ))
2017-04-02 09:49:47 -07:00
2688a81526
Don't suggest indirection for 'declare var$n=foo'
2017-03-18 14:54:52 -07:00
82c3084438
Add HandBrakeCLI to list of stdin swallowing apps
2017-03-18 13:10:54 -07:00
35c74e4747
Getting command name from busybox now gets applet name
2017-02-12 10:56:29 -08:00
41176c23a6
Merge pull request #822 from bittorf/master
...
SC2164: show two possible variants for circumenting the warning
2017-01-15 15:58:19 -08:00
7f307c5775
Count | as a regex metacharacter for 2076.
2017-01-12 19:02:46 -08:00
4e13c7cbc1
SC2164: show two possible variants for circumenting the warning
...
always calling 'exit' is not good in e.g. functions.
the basic idea is at least that the returncode of
cd *is* evaluated somehow and not ignored.
Reported-by: Garance Alistair Drosehn <drosehn@rpi.edu>
Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
2017-01-10 12:30:47 +01:00
edb01fa855
Warn about ( -d foo ) and similar.
2017-01-09 23:49:22 -08:00
43f667a8f9
Update Analytics.hs
2017-01-03 21:48:35 +03:00
daacc98a8f
Update Analytics.hs
2017-01-03 21:40:32 +03:00
40907b1636
This commit fixes #803
2017-01-03 14:55:12 +00:00
96168fc707
This commit fixes #797
2017-01-02 18:01:24 +00:00
6aee12a572
Warnings for braces/globs/arrays in [/[[.
2016-12-31 13:18:36 -08:00
30e94ea7ab
Warn about comparisons and cases that can never match.
2016-12-29 14:04:49 -08:00
5669702362
Warn about missing and invalid subscripts in array assignments.
2016-12-28 18:58:03 -08:00
bd9d05c759
Warn about missing space in [ foo= bar ]
2016-12-27 21:20:59 -08:00
7124c113e8
Don't warn about .sh.version being unused (for Ksh)
2016-12-17 16:03:06 -08:00
f594f01d35
Add warnings about redirections without commands.
2016-12-17 15:03:52 -08:00
6ccb7e9129
Fix 'for file; do ..' counting $file as a safe variable.
2016-12-17 12:55:14 -08:00
Vidar Holen
Vladimir Panteleev
Mike Frysinger
koalaman
Luke Shumaker
mr.Shu
Vaibhav Sagar
Bastian Bittorf
Ekaterina Efimova