Ng Zhi An
8ff35fb4af
Add end pos to readSingleQuoted
2018-06-07 23:09:59 -07:00
Ng Zhi An
29e8c0a16e
Add end pos to readDollarBraced
2018-06-07 22:25:16 -07:00
Ng Zhi An
3848788c2d
Add end pos to readDollarVariable
2018-06-07 21:55:41 -07:00
Ng Zhi An
0c459ae2cb
Add function to set end pos of start id
2018-06-07 21:55:41 -07:00
Ng Zhi An
e496b413bd
Remove usage of withNextId
2018-06-07 21:55:41 -07:00
Ng Zhi An
48ac654a93
Merge end pos map into start pos map
2018-06-07 21:55:41 -07:00
Russell Harmon
4470fe715c
Support emitting a correct end column on SC2086
...
This does the necessary work to emit end columns on AST analyses. SC2086
is made to emit a correct end column as an illustrative example.
For example:
```
$ shellcheck -s bash -f json /dev/stdin <<< 'echo $1'
[{"file":"/dev/stdin","line":1,"endLine":1,"column":6,"endColumn":8,"level":"info","code":2086,"message":"Double quote to prevent globbing and word splitting."}]
```
This change deprecates the parser's getNextId and getNextIdAt, replacing
it with a new withNextId function. This function has the type signature:
withNextId :: Monad m => ParsecT s UserState (SCBase m) (Id -> b) -> ParsecT s UserState (SCBase m) b
Specifically, it should be used to wrap read* functions and will pass in
a newly generated Id which should be used to represent that node.
Sub-parsers will need their own call to withNextId in order to get a
unique Id.
In doing this, withNextId can now track both the entry and exit position
of every read* parser which uses it, enabling the tracking of end
columns throughout the application.
2018-06-07 21:55:41 -07:00
Vidar Holen
379321d1f3
Show tags in travis output
2018-06-07 20:40:44 -07:00
Vidar Holen
0adea473fd
Update CHANGELOG after release
2018-06-07 20:19:00 -07:00
Vidar Holen
a3be776f80
Stable version 0.5.0
...
This release is dedicated to Valve for keeping PC gaming awesome.
Also, for that time they proved the need for a tool like ShellCheck.
2018-05-31 20:01:42 -07:00
Vidar Holen
b5e5d249c4
Merge pull request #1237 from ngzhian/1234
...
Check if builtin cd is called
2018-05-27 18:34:18 -07:00
Vidar Holen
efffc6150b
Warn about string operations on $@/$* ( fixes #1236 )
2018-05-27 12:53:01 -07:00
Ng Zhi An
cb4a0c0250
Check if builtin cd is called
...
Fixes #1234
2018-05-27 11:42:37 -07:00
Vidar Holen
135cf5932f
Parse here docs as per spec ( fixes #1050 )
2018-05-26 21:01:18 -07:00
Vidar Holen
467dfe07b6
Add a unit test and separate ids for 884eff0c
2018-05-23 19:51:36 -07:00
Vidar Holen
d140388bea
Merge pull request #1232 from ngzhian/source-x
...
Add T_SourceCommand to wrap source commands and sourced code
2018-05-23 19:41:55 -07:00
Ng Zhi An
884eff0c36
Add T_SourceCommand to wrap source commands and sourced code
...
Fixes #1181
2018-05-22 22:43:26 -07:00
Vidar Holen
1d8047cce1
Warn about unnecessary subshells in tests
2018-05-22 22:35:37 -07:00
Vidar Holen
77546fba2f
Merge pull request #1223 from ngzhian/1124
...
Handle offset references of the form [foo]:bar (fixes #1124 )
2018-05-20 17:26:08 -07:00
Vidar Holen
4a5ee06ce4
Merge pull request #1206 from ngzhian/aeson
...
Change to aeson (fixes #1085 )
2018-05-20 17:19:20 -07:00
Ng Zhi An
4dceecb1ed
Handle offset references of the form [foo]:bar ( fixes #1124 )
2018-05-13 22:48:02 -07:00
Vidar Holen
5b226e733b
Merge pull request #1203 from ngzhian/1199
...
Whitelist rename for SC2016 (fixes #1199 )
2018-05-13 16:56:09 -07:00
Vidar Holen
46c10c1571
Merge branch 'master' into 1199
2018-05-13 16:55:53 -07:00
Vidar Holen
1de8ba0210
Merge pull request #1208 from ngzhian/1186
...
Add unset to list of commands exempt from 2016
2018-05-13 16:47:29 -07:00
Vidar Holen
407f6a63b9
Merge branch 'master' into 1186
2018-05-13 16:47:18 -07:00
Vidar Holen
7ee7448a70
Merge pull request #1221 from ngzhian/1192
...
Assignments are okay in SC2094 (fixes #1192 )
2018-05-13 16:44:11 -07:00
Vidar Holen
48ebd41e22
Merge pull request #1222 from ngzhian/196
...
Suppress SC2016 for git filter-branch (fixes #196 )
2018-05-13 15:45:20 -07:00
Ng Zhi An
0c88fbc76d
Suppress SC2016 for git filter-branch ( fixes #196 )
2018-05-13 15:18:55 -07:00
Ng Zhi An
b3362f1dc3
Assignments are okay in SC2094 ( fixes #1192 )
2018-05-13 15:17:32 -07:00
Ng Zhi An
2c6bc43614
Add Data.Monoid
2018-05-13 11:44:21 -07:00
Vidar Holen
235bf6605f
Merge pull request #1205 from ngzhian/remove-unused
...
Remove unused code
2018-05-12 19:15:42 -07:00
Vidar Holen
7029a713c7
Merge pull request #1207 from ngzhian/1184
...
When given a %* format string, expect one more argument
2018-05-12 18:50:23 -07:00
Vidar Holen
cf608dc2f6
Parse FD move operations like 2>&1- correctly. Fixes #1180 .
2018-05-12 18:30:35 -07:00
Vidar Holen
aa3b3fdc56
Make .ghci look in ./src
2018-05-12 17:47:21 -07:00
Vidar Holen
bca2ad4e18
Don't think declare -x -F var is used ( fixes #1209 ).
2018-05-12 17:34:23 -07:00
Vidar Holen
719e1854e5
Clarify 'export' suggestion in SC2034 (unused vars).
2018-05-11 21:39:54 -07:00
Ng Zhi An
20ad7dc8de
Add unset to list of commands exempt from 2016
...
Fixes #1186
2018-05-06 16:45:57 -07:00
Ng Zhi An
f84859ab90
When given a %* format string, expect one more argument
...
Fixes #1184
2018-05-06 16:39:51 -07:00
Ng Zhi An
08235a1cb2
Change to aeson ( fixes #1085 )
...
Adds bytestring as a dependency for putStrLn encoded values.
2018-05-06 16:07:53 -07:00
Ng Zhi An
728922d2b8
Remove unused code
2018-05-06 15:24:34 -07:00
Ng Zhi An
a953dd3454
Whitelist rename for SC2016 ( fixes #1199 )
2018-05-06 10:28:17 -07:00
Vidar Holen
ef6a5b97b9
Refactor sudo checks into CommandChecks
2018-04-30 22:59:23 -07:00
Vidar Holen
8873a1732b
Merge pull request #1195 from sdknudsen/master
...
Warn about invalid arguments to sudo
2018-04-30 21:50:28 -07:00
Stefan Knudsen
5adfce72e1
Warn about invalid arguments to sudo
2018-04-29 01:16:31 -04:00
Vidar Holen
12b3fdf661
Update gallery of bad code
2018-04-28 12:58:44 -07:00
Vidar Holen
bb4ce86fab
Account for array index in SC2154 ${var:?} ( fixes #1166 )
2018-04-28 12:09:54 -07:00
Vidar Holen
7ec2fa2d3e
Remove 'nice' from list of non-reading commands ( fixes #1169 )
2018-04-28 11:39:42 -07:00
Vidar Holen
5481ccd7f7
Warn about elseif or elsif as command names ( fixes #1177 )
2018-04-27 22:23:37 -07:00
Vidar Holen
a1d8947297
Fix broken test stripping
2018-04-22 14:57:43 -07:00
Vidar Holen
683a30abde
Merge pull request #1174 from rasa/patch-1
...
Added scoop install
2018-04-22 14:13:35 -07:00