087865c680
Clarify 'which'
2021-03-20 20:43:18 -05:00
15ff87cf80
Merge pull request #2119 from josephcsible/refactors
...
Various refactorings
2021-02-02 18:14:27 -08:00
9584266a8b
Escape control characters when adding user data to messages
2020-12-31 12:28:48 -08:00
2cfd1f2714
Fuse maps
2020-12-28 18:13:34 -05:00
8480563672
Use syntactic sugar instead of building lists by hand
2020-12-28 18:13:34 -05:00
0607039d41
Simplify actualArgs
2020-12-28 17:21:47 -05:00
3104cec770
SC2267: Warn about xargs -i ( fixes #2058 )
2020-10-18 22:10:14 -07:00
f100c2939e
Rewrite getopts style option parser
2020-10-18 21:34:58 -07:00
14e6806092
Handle literal linefeeds in printf format strings ( fixes #2007 )
2020-07-25 17:36:22 -07:00
75863a887e
Merge pull request #1918 from josephcsible/getsuspiciousregexwildcard
...
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 15:32:00 -07:00
58d3e50f43
Merge pull request #1905 from josephcsible/skiprepeating
...
Make skipRepeating lazier and faster
2020-04-12 15:21:39 -07:00
73cc11fd0a
Merge pull request #1901 from josephcsible/bracedstring
...
Mostly get rid of bracedString
2020-04-12 15:14:50 -07:00
163c710ba7
Clean up and optimize getSuspiciousRegexWildcard
2020-04-12 16:15:45 -04:00
999b7e2596
Get rid of bracedString everywhere it's easy to
2020-04-11 19:24:11 -04:00
a9d564a8bc
Combine bracedString into getSingleUnmodifiedVariable
...
Everywhere we used getSingleUnmodifiedVariable, we just called bracedString on
the result. Move this into that function instead, and rename it accordingly.
2020-04-11 19:23:13 -04:00
cd38afce26
Make it slightly lazier still (and more clear)
2020-04-05 21:46:08 -04:00
5084ba8d7e
Make skipRepeating lazier and faster
2020-04-05 21:39:14 -04:00
ed331b816b
Simplify warnRedundant
2020-04-05 20:32:39 -04:00
cfa2a663af
Simplify checkSetAssignment
2020-04-05 20:30:37 -04:00
df4928f4e3
Use MultiWayIf instead of case-matching on ()
2020-04-05 20:30:37 -04:00
9747b1d5c3
Simplify checkArg
2020-04-05 20:10:56 -04:00
fa841cb270
Prefer pattern matching in undirected
2020-04-05 20:08:02 -04:00
e8501151dd
Use a guard instead of unless
2020-04-05 20:04:54 -04:00
9027a9239f
Use pattern matching instead of snd
2020-04-05 20:03:17 -04:00
773e98868d
Use foldr in checkFindNameGlob
2020-04-05 19:53:40 -04:00
eecd003e2d
Optimize patterns in checkFindNameGlob
...
1. Instead of pattern-matching the same list multiple times, do it only
once and then pass the pieces separately.
2. Don't reconstruct an object equivalent to one we just deconstructed.
2020-02-11 01:04:49 -05:00
440d0038aa
Remove a partial pattern match equivalent to fromJust from checkFindNameGlob
2020-02-11 01:03:10 -05:00
d0beac6d0b
Merge pull request #1826 from josephcsible/nofromjust
...
Use the Identity monad to avoid unnecessary uses of fromJust
2020-02-10 18:05:36 -08:00
6d06103cab
Remove unnecessary uses of head
2020-02-09 23:18:09 -05:00
7e6a556ef1
Get rid of potentially
...
This already exists as sequence_.
2020-02-09 23:17:52 -05:00
ffbbfcfe25
Use mapM_ and sequence_ instead of reimplementing them
2020-02-09 23:17:52 -05:00
cc424bac11
Use find instead of take 1 and filter
2020-02-09 23:17:52 -05:00
4d92a2e15c
Add getLiteralStringDef and simplify with it
2020-02-09 21:36:38 -05:00
f8648e5465
Switch getLiteralStringExt to Identity where it can never be Nothing
2020-02-09 21:26:42 -05:00
aaffe38198
Use the Identity monad to avoid unnecessary uses of fromJust
2020-02-08 23:20:54 -05:00
c29b6afa56
Use null instead of comparing with empty lists
2020-02-01 23:04:04 -05:00
e6e89d68fd
Use list comprehensions instead of clunky combinations of map and filter
2020-02-01 23:04:04 -05:00
d7278b95f2
Remove unnecessary "map snd"
2020-02-01 22:50:19 -05:00
cbcca528ae
Merge branch 'iss1724-builtin-support' of https://github.com/jabberabbe/shellcheck into jabberabbe-iss1724-builtin-support
2019-12-21 18:13:07 -08:00
0f15fa49ba
Make SC2230 optional
2019-12-07 16:11:49 -08:00
84ca7711c4
Make command-specific checks act on `builtin ...`
...
Now if shellchecks encounters a command like `builtin cmd ...`
it applies the same check that would be applied to `cmd ...`.
2019-11-01 14:28:00 +01:00
4dfd7eb1cf
Use single quotes for the format string example in SC2059
2019-10-24 10:33:17 -07:00
7473d4a743
Make `read -t 0` test more forgiving towards other flags
2019-10-12 20:45:36 -07:00
023ae5dfda
Don't warn about printf '%()T' without corresponding argument
2019-07-20 15:10:41 -07:00
914974bd4f
Don't consider `.*` a glob-like regex ( fixes #1214 )
2019-07-04 17:41:23 -07:00
c0d3a98fcd
Add warning for chmod -r ( fixes #1321 )
2019-07-04 16:54:42 -07:00
52a9d90e1a
Merge pull request #1580 from virgilwashere/copyright
...
Update Copyright to year 2019; README linting
2019-05-19 12:03:15 -07:00
aa3b709b5d
Track whether braces were present in T_DollarBraced
...
References of the form $var and ${var} both map to the same structure in
the AST, which prevents any later analysis functions from distinguishing
them. In preparation for adding checks that need this info, add a Bool
to T_DollarBraced that tracks whether the braces were seen at parsing
time and update all references so that this change is a no-op.
2019-05-14 11:01:38 -06:00
ea05271fa3
📝 Update Copyright to year 2019 and Markdown linting
...
- [x] 📝 Update Copyright to year 2019
- [x] 📝 MD009/no-trailing-spaces: Trailing spaces [Expected: 0 or 2; Actual: 1]
- [x] 📝 MD034/no-bare-urls: Bare URL used
- [ ] 📝 ~MD004/ul-style: Unordered list style [Expected: dash; Actual: asterisk]~
- [ ] ~add missing TOC entries~
2019-05-14 20:12:34 +10:00
a03d94c0b2
Merge pull request #1468 from Gandalf-/issue_824_grep_fixed_strings
...
Issue 824 grep fixed strings and SC2063
2019-01-20 14:06:40 -08:00
Matthias Diener
Vidar Holen
Joseph C. Sible
Tito Sacchi
Benjamin Gordon
Virgil
Vidar Holen