7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only trigger SC2316 on unquoted words.

This commit is contained in:
Vidar Holen 2022-05-06 10:06:12 -07:00
parent 7c44e1060f
commit fd595d1058
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ShellCheck/Checks/Commands.hs
View File

@ -948,10 +948,11 @@ prop_checkMultipleDeclaring3 = verify (checkMultipleDeclaring "readonly") "reado
prop_checkMultipleDeclaring4 = verify (checkMultipleDeclaring "export") "export readonly foo=5" prop_checkMultipleDeclaring4 = verify (checkMultipleDeclaring "export") "export readonly foo=5"
prop_checkMultipleDeclaring5 = verifyNot (checkMultipleDeclaring "local") "f() { local -r foo=5; }" prop_checkMultipleDeclaring5 = verifyNot (checkMultipleDeclaring "local") "f() { local -r foo=5; }"
prop_checkMultipleDeclaring6 = verifyNot (checkMultipleDeclaring "declare") "declare -rx foo=5" prop_checkMultipleDeclaring6 = verifyNot (checkMultipleDeclaring "declare") "declare -rx foo=5"
prop_checkMultipleDeclaring7 = verifyNot (checkMultipleDeclaring "readonly") "readonly 'local' foo=5"
checkMultipleDeclaring cmd = CommandCheck (Exactly cmd) (mapM_ check . arguments) checkMultipleDeclaring cmd = CommandCheck (Exactly cmd) (mapM_ check . arguments)
where where
check t = sequence_ $ do check t = sequence_ $ do
lit <- getLiteralString t lit <- getUnquotedLiteral t
guard $ lit `elem` declaringCommands guard $ lit `elem` declaringCommands
return $ err (getId $ getCommandTokenOrThis t) 2316 $ return $ err (getId $ getCommandTokenOrThis t) 2316 $
"This applies " ++ cmd ++ " to the variable named " ++ lit ++ "This applies " ++ cmd ++ " to the variable named " ++ lit ++