From fb5f72951da1e62569a2e339c23386ad299c23c2 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Thu, 12 Sep 2013 19:11:42 -0700 Subject: [PATCH] Don't warn about unused variables for read '' --- ShellCheck/Analytics.hs | 1 + ShellCheck/Data.hs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ShellCheck/Analytics.hs b/ShellCheck/Analytics.hs index 7db2b30..ae513eb 100644 --- a/ShellCheck/Analytics.hs +++ b/ShellCheck/Analytics.hs @@ -1683,6 +1683,7 @@ prop_checkUnused5 = verifyNotFull checkUnusedAssignments "read lol; echo $lol" prop_checkUnused6 = verifyNotFull checkUnusedAssignments "var=4; (( var++ ))" prop_checkUnused7 = verifyNotFull checkUnusedAssignments "var=2; $((var))" prop_checkUnused8 = verifyFull checkUnusedAssignments "var=2; var=3;" +prop_checkUnused9 = verifyNotFull checkUnusedAssignments "read ''" checkUnusedAssignments t = snd $ runState (mapM_ checkAssignment flow) [] where flow = getVariableFlow t diff --git a/ShellCheck/Data.hs b/ShellCheck/Data.hs index 90083a5..f26f327 100644 --- a/ShellCheck/Data.hs +++ b/ShellCheck/Data.hs @@ -2,7 +2,7 @@ module ShellCheck.Data where internalVariables = [ -- Generic - "_", + "", "_", -- Bash "BASH", "BASHOPTS", "BASHPID", "BASH_ALIASES", "BASH_ARGC",