7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify functionMap and remove unnecessary partiality

This commit is contained in:
Joseph C. Sible 2023-12-21 13:35:22 -05:00
parent bfe4342697
commit f983d9ae93
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ShellCheck/Analytics.hs
View File

@ -2825,13 +2825,11 @@ checkUnpassedInFunctions params root =
execWriter $ mapM_ warnForGroup referenceGroups execWriter $ mapM_ warnForGroup referenceGroups
where where
functionMap :: Map.Map String Token functionMap :: Map.Map String Token
functionMap = Map.fromList $ functionMap = Map.fromList $ execWriter $ doAnalysis (tell . maybeToList . findFunction) root
map (\t@(T_Function _ _ _ name _) -> (name,t)) functions
functions = execWriter $ doAnalysis (tell . maybeToList . findFunction) root
findFunction t@(T_Function id _ _ name body) findFunction t@(T_Function id _ _ name body)
| any (isPositionalReference t) flow && not (any isPositionalAssignment flow) | any (isPositionalReference t) flow && not (any isPositionalAssignment flow)
= return t = return (name,t)
where flow = getVariableFlow params body where flow = getVariableFlow params body
findFunction _ = Nothing findFunction _ = Nothing