7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1898 from josephcsible/nameexpansion 

Simplify nameExpansion
This commit is contained in:
Vidar Holen 2020-04-11 16:18:54 -07:00 committed by GitHub
parent 01f4423465 d2fa88dd91
commit f8c1ffb0dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ShellCheck/AnalyzerLib.hs
View File

@ -840,10 +840,9 @@ getBracedReference s = fromMaybe s $
if c `elem` "*@#?-$!" then return [c] else fail "not special" if c `elem` "*@#?-$!" then return [c] else fail "not special"
getSpecial _ = fail "empty" getSpecial _ = fail "empty"
nameExpansion ('!':rest) = do -- e.g. ${!foo*bar*} nameExpansion ('!':next:rest) = do -- e.g. ${!foo*bar*}
let suffix = dropWhile isVariableChar rest guard $ isVariableChar next -- e.g. ${!@}
guard $ suffix /= rest -- e.g. ${!@} first <- find (not . isVariableChar) rest
first <- suffix !!! 0
guard $ first `elem` "*?" guard $ first `elem` "*?"
return "" return ""
nameExpansion _ = Nothing nameExpansion _ = Nothing