From f7b82658f461832102e970b576916f4c84e3f247 Mon Sep 17 00:00:00 2001 From: Vidar Holen Date: Wed, 17 Oct 2018 09:00:52 -0700 Subject: [PATCH] Add $# to list of variables not containing spaces (fixes #1362) --- src/ShellCheck/Analytics.hs | 1 + src/ShellCheck/Data.hs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ShellCheck/Analytics.hs b/src/ShellCheck/Analytics.hs index 6a97563..2904812 100644 --- a/src/ShellCheck/Analytics.hs +++ b/src/ShellCheck/Analytics.hs @@ -1601,6 +1601,7 @@ prop_checkSpacefulness32= verifyNotTree checkSpacefulness "var=$1; [ -v var ]" prop_checkSpacefulness33= verifyTree checkSpacefulness "for file; do echo $file; done" prop_checkSpacefulness34= verifyTree checkSpacefulness "declare foo$n=$1" prop_checkSpacefulness35= verifyNotTree checkSpacefulness "echo ${1+\"$1\"}" +prop_checkSpacefulness36= verifyNotTree checkSpacefulness "arg=$#; echo $arg" checkSpacefulness params t = doVariableFlowAnalysis readF writeF (Map.fromList defaults) (variableFlow params) diff --git a/src/ShellCheck/Data.hs b/src/ShellCheck/Data.hs index 1fd42b8..8ce0026 100644 --- a/src/ShellCheck/Data.hs +++ b/src/ShellCheck/Data.hs @@ -39,7 +39,7 @@ internalVariables = [ ] variablesWithoutSpaces = [ - "$", "-", "?", "!", + "$", "-", "?", "!", "#", "BASHPID", "BASH_ARGC", "BASH_LINENO", "BASH_SUBSHELL", "EUID", "LINENO", "OPTIND", "PPID", "RANDOM", "SECONDS", "SHELLOPTS", "SHLVL", "UID", "COLUMNS", "HISTFILESIZE", "HISTSIZE", "LINES"