7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge branch '1416-encourage-n' of https://github.com/ngzhian/shellcheck into ngzhian-1416-encourage-n

This commit is contained in:
Vidar Holen 2018-12-28 15:56:15 -08:00
parent ef811995fa 95a8cf93c9
commit f6bc009331
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/ShellCheck/Analytics.hs
View File

@ -170,6 +170,7 @@ nodeChecks = [
,checkSubshelledTests ,checkSubshelledTests
,checkInvertedStringTest ,checkInvertedStringTest
,checkRedirectionToCommand ,checkRedirectionToCommand
,checkNullaryExpansionTest
] ]
@ -3096,5 +3097,21 @@ checkRedirectionToCommand _ t =
warn id 2238 "Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)?" warn id 2238 "Redirecting to/from command name instead of file. Did you want pipes/xargs (or quote to ignore)?"
_ -> return () _ -> return ()
prop_checkNullaryExpansionTest1 = verify checkNullaryExpansionTest "[[ $(a) ]]"
prop_checkNullaryExpansionTest2 = verify checkNullaryExpansionTest "[[ $a ]]"
prop_checkNullaryExpansionTest3 = verifyNot checkNullaryExpansionTest "[[ $a=1 ]]"
prop_checkNullaryExpansionTest4 = verifyNot checkNullaryExpansionTest "[[ -n $(a) ]]"
checkNullaryExpansionTest _ t =
case t of
TC_Nullary _ _ (T_NormalWord id [T_DollarExpansion _ [T_Pipeline _ [] [x]]]) ->
when (isJust (getCommand x)) $
style id 2243 (
"To check for the exit code of a command, remove the conditional expression, e.g. if foo; ...")
TC_Nullary _ _ (T_NormalWord id [t2]) ->
when ((not . isConstant) t2) $
style id 2244 (
"Use -n to check for null string, e.g. [[ -n $var ]].")
_ -> return ()
return [] return []
runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |]) runTests = $( [| $(forAllProperties) (quickCheckWithResult (stdArgs { maxSuccess = 1 }) ) |])