7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-08-08 18:52:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Get rid of a dangerous partial function from checkSpacefulnessCfg'

Browse Source
This commit is contained in:
Joseph C. Sible
2023-05-24 16:38:53 -04:00
parent 824c802b63
commit f03c437e2f
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/ShellCheck/Analytics.hs
View File

@@ -2134,7 +2134,8 @@ checkSpacefulnessCfg' dirtyPass params token@(T_DollarBraced id _ list) =
addDoubleQuotesAround params token
where
name = getBracedReference $ concat $ oversimplify list
bracedString = concat $ oversimplify list
name = getBracedReference bracedString
parents = parentMap params
needsQuoting =
not (isArrayExpansion token) -- There's another warning for this
@@ -2153,14 +2154,10 @@ checkSpacefulnessCfg' dirtyPass params token@(T_DollarBraced id _ list) =
|| CF.spaceStatus (CF.variableValue state) == CF.SpaceStatusClean
isDefaultAssignment parents token =
let modifier = getBracedModifier $ bracedString token in
let modifier = getBracedModifier bracedString in
any (`isPrefixOf` modifier) ["=", ":="]
&& isParamTo parents ":" token
-- Given a T_DollarBraced, return a simplified version of the string contents.
bracedString (T_DollarBraced _ _ l) = concat $ oversimplify l
bracedString _ = error $ pleaseReport "bracedString on non-variable"
checkSpacefulnessCfg' _ _ _ = return ()