From e0fbb8326473fd4ff355771e71b5754c1fe0718d Mon Sep 17 00:00:00 2001 From: Adrian Fluturel Date: Tue, 7 Jan 2025 11:47:23 +0100 Subject: [PATCH] Fix tests after making the check optional --- src/ShellCheck/Checker.hs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/ShellCheck/Checker.hs b/src/ShellCheck/Checker.hs index b598723..ca66195 100644 --- a/src/ShellCheck/Checker.hs +++ b/src/ShellCheck/Checker.hs @@ -359,7 +359,7 @@ prop_optionIncludes2 = prop_optionIncludes3 = -- expect 2086, no inclusions provided, so it is reported - [2086, 2331] == checkOptionIncludes Nothing "#!/bin/sh\n var='a b'\n echo $var" + [2086] == checkOptionIncludes Nothing "#!/bin/sh\n var='a b'\n echo $var" prop_optionIncludes4 = -- expect 2086 & 2154, only 2154 included, so only that's reported @@ -400,6 +400,12 @@ prop_canEnableOptionalsWithRc = result == [2244] csScript = "#!/bin/sh\n[ \"$1\" ]" } +prop_canEnableCheckForReadonlyVariables = result == [2331] + where + result = checkWithRc "enable=check-variable-can-be-readonly" emptyCheckSpec { + csScript = "#!/bin/sh\na=3\necho \"$a\"" + } + prop_sourcePathRedirectsName = result == [2086] where f "dir/myscript" _ _ "lib" = return "foo/lib" @@ -520,7 +526,7 @@ prop_hereDocsAreParsedWithoutTrailingLinefeed = 1044 `elem` result prop_hereDocsWillHaveParsedIndices = null result where - result = check "#!/bin/bash\nreadonly my_array=(a b)\ncat <> ./test\n $(( 1 + my_array[1] ))\nEOF" + result = check "#!/bin/bash\nmy_array=(a b)\ncat <> ./test\n $(( 1 + my_array[1] ))\nEOF" prop_rcCanSuppressDfa = null result where