7x31/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-08-08 22:35:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use traverse instead of sequence and map

Browse Source
This commit is contained in:
Joseph C. Sible
2023-12-30 13:59:15 -05:00
parent 3bd7df955b
commit dedf932fe8
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ShellCheck/Analytics.hs
View File

@@ -4936,7 +4936,7 @@ checkOverwrittenExitCode params t =
guard . not $ S.null exitCodeIds guard . not $ S.null exitCodeIds
let idToToken = idMap params let idToToken = idMap params
exitCodeTokens <- sequence $ map (\k -> Map.lookup k idToToken) $ S.toList exitCodeIds exitCodeTokens <- traverse (\k -> Map.lookup k idToToken) $ S.toList exitCodeIds
return $ do return $ do
when (all isCondition exitCodeTokens && not (usedUnconditionally t exitCodeIds)) $ when (all isCondition exitCodeTokens && not (usedUnconditionally t exitCodeIds)) $
warn id 2319 "This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten." warn id 2319 "This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten."