7x31
/
shellcheck
mirror of https://github.com/koalaman/shellcheck.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Check for globs in test, e.g. [[ -e file* ]]

This commit is contained in:
Vidar Holen 2014-05-25 12:04:18 -07:00
parent 1af23fd131
commit d830a36bc8
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ShellCheck/Analytics.hs
View File

@ -200,6 +200,7 @@ nodeChecks = [
,checkSuspiciousIFS ,checkSuspiciousIFS
,checkAliasesUsesArgs ,checkAliasesUsesArgs
,checkShouldUseGrepQ ,checkShouldUseGrepQ
,checkTestGlobs
] ]
@ -2800,3 +2801,10 @@ checkShouldUseGrepQ params t =
T_Pipeline _ _ cmds -> return cmds T_Pipeline _ _ cmds -> return cmds
_ -> fail "unknown" _ -> fail "unknown"
isGrep = isSuffixOf "grep" isGrep = isSuffixOf "grep"
prop_checkTestGlobs1 = verify checkTestGlobs "[ -e *.mp3 ]"
prop_checkTestGlobs2 = verifyNot checkTestGlobs "[[ $a == *b* ]]"
checkTestGlobs params (TC_Unary _ _ op token) | isGlob token =
err (getId token) 2144 $
op ++ " doesn't work with globs. Use a for loop."
checkTestGlobs _ _ = return ()